Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(vue-next): minify webpack bundle size #3983

Merged
merged 6 commits into from
Sep 29, 2024
Merged

Conversation

yokots
Copy link
Contributor

@yokots yokots commented Aug 6, 2024

just see each commit message.

Before submitting a new pull request, please make sure:

  • Test cases have been added/updated/passed for the code you will submit.
  • Documentation has added or updated.
  • Commit message is following the Convention Commit guideline with maximum 72 characters.
  • Squash the repeat code commits, short patches are welcome.

Current ttypescript version not support node v16.20.2, the latest v16 version.
It will cause this issue: cevek/ttypescript#150
align patchProps types with vue runtime core, but
there also have some spec tests to fix
just like fromSsrAstNodes, optimize the output in hippy-vue-css-loader,
and make hippy-vue-next-style-parser to compatible with old and new format.
webpack.NamedModulesPlugin was deprecated in v4 and removed in v5.
these plugin are default in devlopment mode and should not be configured in production mode,
because it will expose file path and increase bundle sizes.

https://v4.webpack.js.org/migrate/4/#deprecatedremoved-plugins
@tencent-adm
Copy link
Member

tencent-adm commented Aug 6, 2024

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
0 out of 2 committers have signed the CLA.

❌ yokots
❌ zealotchen0
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link

hippy-service bot commented Aug 6, 2024

Hi, @yokots. Thanks for your PR! 👏

🏷️ You can leave a comment in this PR with #help tag when you need help (e.g. some status checks run failed due to internal issue), admin team members will help asap.

Copy link

hippy-service bot commented Aug 6, 2024

After a quick scan, I have approved workflow to run.

🏷️ New commits in this PR would not be tested automatically until this pull request is reviewed by our collaborators.
🏷️ No need to worry about the status of merge_guard and [gh] pull request merge guard / merge_guard (pull_request_target) checks, once this pull request is met merge requirements, it will be automatically converted to successful status.

@zealotchen0 zealotchen0 changed the title 优化Hippy生成的前端包体机大小 feat(vue-next): minify webpack bundle size Sep 29, 2024
zealotchen0
zealotchen0 previously approved these changes Sep 29, 2024
@zealotchen0 zealotchen0 merged commit 62102ab into Tencent:main Sep 29, 2024
21 of 25 checks passed
zealotchen0 added a commit that referenced this pull request Nov 5, 2024
* chore(drive/js): bump up ttypescript version

Current ttypescript version not support node v16.20.2, the latest v16 version.
It will cause this issue: cevek/ttypescript#150

* fix(hipp-vue-next): correct patchProps types

align patchProps types with vue runtime core, but
there also have some spec tests to fix

* refactor(vue-next): minify generated style code

just like fromSsrAstNodes, optimize the output in hippy-vue-css-loader,
and make hippy-vue-next-style-parser to compatible with old and new format.

* build(example-scripts): remove webpack.NamedModulesPlugin

webpack.NamedModulesPlugin was deprecated in v4 and removed in v5.
these plugin are default in devlopment mode and should not be configured in production mode,
because it will expose file path and increase bundle sizes.

https://v4.webpack.js.org/migrate/4/#deprecatedremoved-plugins

* chore(examples): update vue3 assets

---------

Co-authored-by: zealotchen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc: example driver: js framework: voltron size: m Denotes a PR that changes 100-499 lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants