Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(android): vfs support custom image loader #3947

Merged
merged 2 commits into from
Jul 9, 2024

Conversation

siguangli
Copy link
Collaborator

Before submitting a new pull request, please make sure:

  • Test cases have been added/updated/passed for the code you will submit.
  • Documentation has added or updated.
  • Commit message is following the Convention Commit guideline with maximum 72 characters.
  • Squash the repeat code commits, short patches are welcome.

@siguangli siguangli requested a review from iPel as a code owner July 9, 2024 08:33
@github-actions github-actions bot added renderer: native module: vfs module: android size: m Denotes a PR that changes 100-499 lines labels Jul 9, 2024
@tencent-adm
Copy link
Member

tencent-adm commented Jul 9, 2024

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
0 out of 2 committers have signed the CLA.

❌ siguangli2018
❌ open-hippy
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link

hippy-service bot commented Jul 9, 2024

Hi, @siguangli. Thanks for your PR! 👏

🏷️ You can leave a comment in this PR with #help tag when you need help (e.g. some status checks run failed due to internal issue), admin team members will help asap.

Copy link
Collaborator

@iPel iPel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@hippy-service hippy-service bot added the action(rebase-merge) Rebase and merge action (maybe privileged) label Jul 9, 2024
Copy link

hippy-service bot commented Jul 9, 2024

🎉 It seems that this pull request has been approved by all required reviewers. As it only contains one normal commit, I will rebase and merge it automatically via add action(rebase-merge) label.

@hippy-actions hippy-actions bot enabled auto-merge (rebase) July 9, 2024 08:46
@hippy-actions hippy-actions bot removed the action(rebase-merge) Rebase and merge action (maybe privileged) label Jul 9, 2024
@siguangli siguangli disabled auto-merge July 9, 2024 09:53
@siguangli siguangli merged commit 5f40f8f into Tencent:main Jul 9, 2024
18 of 20 checks passed
@siguangli siguangli deleted the feat/custom_imageLoader branch July 9, 2024 09:54
siguangli added a commit that referenced this pull request Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants