Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(android): add filter for css style to native renderer #3405

Merged
merged 3 commits into from
Jul 24, 2023
Merged

feat(android): add filter for css style to native renderer #3405

merged 3 commits into from
Jul 24, 2023

Conversation

siguangli
Copy link
Collaborator

Before submitting a new pull request, please make sure:

  • Test cases have been added/updated/passed for the code you will submit.
  • Documentation has added or updated.
  • Commit message is following the Convention Commit guideline with maximum 72 characters.
  • Squash the repeat code commits, short patches are welcome.

@github-actions github-actions bot added renderer: native size: s Denotes a PR that changes 10-99 lines labels Jul 24, 2023
@hippy-service
Copy link

hippy-service bot commented Jul 24, 2023

Hi, @siguangli. Thanks for your PR! 👏

🏷️ You can leave a comment in this PR with #help tag when you need help (e.g. some status checks run failed due to internal issue), admin team members will help asap.

@hippy-service
Copy link

hippy-service bot commented Jul 24, 2023

🎉 It seems that this pull request has been approved by all required reviewers. But it has more than one normal commit, I will notify admin team member to merge it manually, please wait a moment.

@siguangli siguangli added the action(squash-merge) Squash and merge action label Jul 24, 2023
@hippy-actions
Copy link

hippy-actions bot commented Jul 24, 2023

⚠️ squash-merge action execution failed, because of pull request title does not meet the Convention Commit guideline.

Please check the following details:

⧗   input: Feat/css props
✖   subject may not be empty [subject-empty]
✖   type may not be empty [type-empty]
✖   header subject cannot be empty [function-rules/header-min-length]
✖   scope may not be empty [scope-empty]

✖   found 4 problems, 0 warnings
ⓘ   Get help: https://github.com/conventional-changelog/commitlint/#what-is-commitlint

@siguangli

@hippy-actions hippy-actions bot added action(squash-merge): failed Squash and merge action execution failed and removed action(squash-merge) Squash and merge action labels Jul 24, 2023
@siguangli siguangli added the action(squash-merge) Squash and merge action label Jul 24, 2023
@hippy-actions hippy-actions bot removed the action(squash-merge): failed Squash and merge action execution failed label Jul 24, 2023
@hippy-actions
Copy link

hippy-actions bot commented Jul 24, 2023

⚠️ squash-merge action execution failed, because of pull request title does not meet the Convention Commit guideline.

Please check the following details:

⧗   input: Feat/css props
✖   subject may not be empty [subject-empty]
✖   type may not be empty [type-empty]
✖   header subject cannot be empty [function-rules/header-min-length]
✖   scope may not be empty [scope-empty]

✖   found 4 problems, 0 warnings
ⓘ   Get help: https://github.com/conventional-changelog/commitlint/#what-is-commitlint

@siguangli

@hippy-actions hippy-actions bot added action(squash-merge): failed Squash and merge action execution failed and removed action(squash-merge) Squash and merge action labels Jul 24, 2023
@siguangli siguangli changed the title Feat/css props feat(android): add filter for css style to native renderer Jul 24, 2023
@siguangli siguangli added the action(squash-merge) Squash and merge action label Jul 24, 2023
@hippy-actions hippy-actions bot removed the action(squash-merge): failed Squash and merge action execution failed label Jul 24, 2023
@hippy-actions
Copy link

hippy-actions bot commented Jul 24, 2023

⚠️ squash-merge action execution failed, because of cannot squash and merge your own pull request.

Please check the following details:

(empty response)

@siguangli

@hippy-actions hippy-actions bot added action(squash-merge): failed Squash and merge action execution failed and removed action(squash-merge) Squash and merge action labels Jul 24, 2023
@zealotchen0 zealotchen0 added action(squash-merge) Squash and merge action and removed action(squash-merge): failed Squash and merge action execution failed labels Jul 24, 2023
@hippy-actions hippy-actions bot enabled auto-merge (squash) July 24, 2023 09:20
@hippy-actions hippy-actions bot removed the action(squash-merge) Squash and merge action label Jul 24, 2023
@hippy-actions hippy-actions bot merged commit 7abe6bc into Tencent:main Jul 24, 2023
@siguangli siguangli deleted the feat/css_props branch July 24, 2023 09:27
zealotchen0 pushed a commit that referenced this pull request Jul 25, 2023
@siguangli @siguangli2018
@ilikethese @zealotchen0
feat(android): add filter for css style to native renderer (#3405)
c459934 
* feat(android): add filter for css style to native renderer

* feat(renderer): android native renderer support style filter

---------

Co-authored-by: maxli <[email protected]>
Co-authored-by: ilikethese <[email protected]>
siguangli added a commit to siguangli/Hippy that referenced this pull request Aug 1, 2023
@siguangli @siguangli2018 @ilikethese
feat(android): add filter for css style to native renderer (Tencent#3405
0106602 
)

* feat(android): add filter for css style to native renderer

* feat(renderer): android native renderer support style filter

---------

Co-authored-by: maxli <[email protected]>
Co-authored-by: ilikethese <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilikethese ilikethese ilikethese approved these changes

Assignees
No one assigned
Labels
renderer: native size: s Denotes a PR that changes 10-99 lines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@siguangli @ilikethese @zealotchen0 @siguangli2018