Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(vue): fix rootview conditional statement #3355

Merged
merged 4 commits into from
Jul 5, 2023
Merged

fix(vue): fix rootview conditional statement #3355

merged 4 commits into from
Jul 5, 2023

Conversation

zealotchen0
Copy link
Collaborator

Pre-PR Checklist

  • I added/updated relevant documentation.
  • I followed the Convention Commit guideline with maximum 72 characters to submit commit message.
  • I squashed the repeated code commits.
  • I signed the [CLA].
  • I added/updated test cases to check the change I am making.
  • All existing and new tests are passing.

@github-actions github-actions bot added driver: js size: xs Denotes a PR that changes 0-9 lines labels Jul 5, 2023
@hippy-service
Copy link

hippy-service bot commented Jul 5, 2023

Hi, @zealotchen0. Thanks for your PR! 👏

🏷️ You can leave a comment in this PR with #help tag when you need help (e.g. some status checks run failed due to internal issue), admin team members will help asap.

@github-actions github-actions bot added gh: workflow size: s Denotes a PR that changes 10-99 lines and removed size: xs Denotes a PR that changes 0-9 lines labels Jul 5, 2023
@zealotchen0 zealotchen0 added the action(squash-merge) Squash and merge action label Jul 5, 2023
@hippy-actions
Copy link

hippy-actions bot commented Jul 5, 2023

⚠️ squash-merge action execution failed, because of cannot squash and merge your own pull request.

Please check the following details:

(empty response)

@zealotchen0

@hippy-actions hippy-actions bot added action(squash-merge): failed Squash and merge action execution failed and removed action(squash-merge) Squash and merge action labels Jul 5, 2023
@zealotchen0 zealotchen0 added action(squash-merge) Squash and merge action and removed action(squash-merge): failed Squash and merge action execution failed labels Jul 5, 2023
@zealotchen0 zealotchen0 requested a review from wwwcg July 5, 2023 12:53
@hippy-actions
Copy link

hippy-actions bot commented Jul 5, 2023

⚠️ squash-merge action execution failed, because of cannot squash and merge your own pull request.

Please check the following details:

(empty response)

@zealotchen0

@hippy-actions hippy-actions bot added action(squash-merge): failed Squash and merge action execution failed and removed action(squash-merge) Squash and merge action labels Jul 5, 2023
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (main@85b0d2f). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #3355   +/-   ##
=======================================
  Coverage        ?   53.47%           
=======================================
  Files           ?       33           
  Lines           ?     2274           
  Branches        ?        0           
=======================================
  Hits            ?     1216           
  Misses          ?     1058           
  Partials        ?        0

@zealotchen0 zealotchen0 enabled auto-merge (squash) July 5, 2023 12:56
@hippy-service
Copy link

hippy-service bot commented Jul 5, 2023

🎉 It seems that this pull request has been approved by all required reviewers. But it has more than one normal commit, I will notify admin team member to merge it manually, please wait a moment.

@zealotchen0 zealotchen0 closed this Jul 5, 2023
auto-merge was automatically disabled July 5, 2023 13:00

Pull request was closed

@zealotchen0 zealotchen0 reopened this Jul 5, 2023
@zealotchen0 zealotchen0 added action(squash-merge) Squash and merge action and removed action(squash-merge): failed Squash and merge action execution failed labels Jul 5, 2023
@hippy-actions
Copy link

hippy-actions bot commented Jul 5, 2023

⚠️ squash-merge action execution failed, because of cannot squash and merge your own pull request.

Please check the following details:

(empty response)

@zealotchen0

@hippy-actions hippy-actions bot added action(squash-merge): failed Squash and merge action execution failed and removed action(squash-merge) Squash and merge action labels Jul 5, 2023
@zealotchen0 zealotchen0 merged commit a156a22 into Tencent:main Jul 5, 2023
zealotchen0 added a commit that referenced this pull request Jul 25, 2023
@zealotchen0
fix(vue): fix rootview conditional statement (#3355)
5364548 
* fix(vue): fix rootview conditional statement

* fix(test): fix js build test

* fix(test): fix js build test

* fix(test): fix js build test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wwwcg wwwcg wwwcg approved these changes

Assignees
No one assigned
Labels
action(squash-merge): failed Squash and merge action execution failed driver: js gh: workflow size: s Denotes a PR that changes 10-99 lines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zealotchen0 @codecov-commenter @wwwcg