feat: add http headers #202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mleone87
reviewed
Oct 4, 2022
cli/cobra.go
Outdated
| @@ -59,7 +59,10 @@ func Client(apiUlr, userID, password, otp string) (c *proxmox.Client, err error) | |||
| if otp == "" { | |||
| otp = os.Getenv("PM_OTP") | |||
| } | |||
| c, err = proxmox.NewClient(apiUlr, nil, tlsconf, proxyUrl, timeout) | |||
| if http_headers == "" { | |||
| otp = os.Getenv("HTTP_HEADERS") | |||
There was a problem hiding this comment.
Yeah, overlooked it my bad.
mleone87
reviewed
Oct 5, 2022
cli/cobra.go
Outdated
| @@ -59,7 +59,10 @@ func Client(apiUlr, userID, password, otp string) (c *proxmox.Client, err error) | |||
| if otp == "" { | |||
| otp = os.Getenv("PM_OTP") | |||
| } | |||
| c, err = proxmox.NewClient(apiUlr, nil, tlsconf, proxyUrl, timeout) | |||
| if http_headers == "" { | |||
| http_headers = os.Getenv("HTTP_HEADERS") | |||
There was a problem hiding this comment.
I would use PM_HTTP_HEADERS for coherence with other envs, what do you think?
There was a problem hiding this comment.
Works out for me.
|
I just ran this PR code with no PM_HTTP_HEADERS set and it does not work
|
frostyfab
pushed a commit
to frostyfab/proxmox-api-go
that referenced
this pull request
Nov 17, 2023
feat: add http headers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for http headers, fixes feature request #196.
Credits to @forthal for helping me out.