Support Odoo v11 🎉 #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lasley
reviewed
Oct 2, 2017
8.0.Dockerfile
Outdated
| @@ -0,0 +1 @@ | |||
| 10.0.Dockerfile | |||
There was a problem hiding this comment.
IMO the 8.0 should be the one containing the Dockerfile, with the older newer ones inheriting. This would align with what we will do when the 12.0 comes out, inheriting the old unless there is some new installation.
lasley
reviewed
Oct 2, 2017
| libfreetype6 liblcms2-2 libtiff5 tk tcl libpq5 \ | ||
| libldap-2.4-2 libsasl2-2 libx11-6 libxext6 libxrender1 \ | ||
| locales-all zlibc \ | ||
| bzip2 ca-certificates curl gettext-base git gnupg2 nano \ |
There was a problem hiding this comment.
gnupg2
Whoah. We gained something GPG in Odoo 11?!
There was a problem hiding this comment.
No, it's just required to install node + npm below. It seems debian 9 doesn't bundle npm.
|
😆 I love the cascading fixups. They're almost entrancing |
… Support Odoo v11 🎉
… fixup! Support Odoo v11 🎉
… fixup! fixup! Support Odoo v11 🎉
… fixup! fixup! fixup! Support Odoo v11 🎉
… fixup! fixup! fixup! fixup! Support Odoo v11 🎉
lasley
reviewed
Oct 4, 2017
| @@ -194,6 +185,9 @@ def test_dotd(self): | |||
| ("--version",), | |||
| ) | |||
|
|
|||
| @unittest.skipUnless( | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wip
closes #22