Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sdist functionality #9

Open
keriksson-rosenqvist opened this issue Oct 13, 2023 · 1 comment
Open

sdist functionality #9

keriksson-rosenqvist opened this issue Oct 13, 2023 · 1 comment

Comments

@keriksson-rosenqvist
Copy link

Based on the package name I was hoping that this package would replace path dependencies for both wheel and sdist builds but from quick testing it seems only wheel builds are updated. Is there intent to have sdist builds functionality as well?

@d-ryan-ashcraft
Copy link
Contributor

d-ryan-ashcraft commented May 13, 2024

Pulled the habushu-mixology-comsumer artifacts from test.pypi.org to see what is going on:

  • wheel files are making the substitution, as expected. For instance, from the contents of METADATA:
Metadata-Version: 2.1
Name: habushu_mixology_consumer
Version: 2.14.0.dev1715088202
...
Requires-Dist: habushu_mixology (==2.14.0.*)
  • Similarly, we see the same in the sdist. For instance, from the contents of PKG-INFO:
Metadata-Version: 2.1
Name: habushu_mixology_consumer
Version: 2.14.0.dev1715088202
...
Requires-Dist: habushu_mixology (==2.14.0.*)
  • However, the sdist also has a pyproject.toml that is NOT getting the mono-repo dependency substituted, but IS getting the version of the module itself substituted:
[tool.poetry]
name = "habushu_mixology_consumer"
version = "2.14.0.dev1715088202"
...
[tool.poetry.dependencies]
habushu-mixology = {path = "../habushu-mixology", develop = true}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants