Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show github changes between actual and previous run #5

Open
joanhey opened this issue Dec 13, 2018 · 1 comment
Open

Show github changes between actual and previous run #5

joanhey opened this issue Dec 13, 2018 · 1 comment
Assignees

Comments

@joanhey
Copy link

joanhey commented Dec 13, 2018

First we added a link to the commit tree #3 of each run.

Now we can add the changes from one run to another.
Really useful to see the changes in github when results change.

compare/{actual-commit-id}...{previous-commit-id}

Example:
TechEmpower/FrameworkBenchmarks@b6bcbba...1e29786

This show the changes from the actual run vs the previous worked run.

@joanhey joanhey changed the title Add changes between actual and previous run Show github changes between actual and previous run Dec 13, 2018
@michaelhixson
Copy link
Contributor

Sounds reasonable. It emails us this link when the final zip file for a run is uploaded, so the logic for this is buried in UploadResultsHandler. I can move that logic into a place where the results details page can use it too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants