Trying to make the DDR A3 theme mimic DDR Ace's announcer engine. I made some progress but hit a wall. This is the code I have on ScreenGameplay overlay. I know beware was the only one to achieve this on his special fork of StepMania. I guess I have to study DDR A - A3's engine OutFox/ITGmania

[makoflagkk]

I kinda am achieveing it to make it very close to DDR Ace but it seems like the announcer is too rigid. Like I notice while playing Ace the announcer can change depending on the frequency of the song and certain combo milestones. For example if you play beginner the announcer will sound earlier and a slower song that starts later the announcer will sound early and go off at the 50 combo milestone . This is the code I made so far. I renamed all announcer folders to stop engine sounds from playing

Here is my code I made.

local t = Def.ActorFrame{}
local soundPlaying = false
local lastComboMilestonePlayed = 0
local lastCheeringComboPlayed = 0
local lastTimeMilestonePlayed = 0
local comboCooldown = 5 -- Cooldown period for combo milestones
local cheeringCooldown = 5 -- Cooldown period for cheering

for pn in ivalues(GAMESTATE:GetHumanPlayers()) do
t[#t+1] = LoadActor("FullCombo", pn)
end

t[#t+1] = LoadActor("GameOver")

local currentSong = GAMESTATE:GetCurrentSong()
local bpm = currentSong and currentSong:GetDisplayBpms()[2] or 120 -- Default BPM if currentSong is nil
local songLength = currentSong and currentSong:GetLastSecond() or 180 -- Default length if currentSong is nil

if currentSong and currentSong:GetDisplayFullTitle() == "LET'S CHECK YOUR LEVEL!" then
t[#t+1] = LoadActor("LET'S CHECK YOUR LEVEL!")
elseif currentSong and currentSong:GetDisplayFullTitle() == "Lesson by DJ" then
t[#t+1] = LoadActor("Lesson by DJ")
end

-- Function to determine combo thresholds based on BPM
local function getComboThresholds(bpm)
local milestones = {}
local baseThreshold = 50

if bpm >= 200 then
    baseThreshold = 20
elseif bpm >= 180 then
    baseThreshold = 25
elseif bpm >= 160 then
    baseThreshold = 30
elseif bpm >= 140 then
    baseThreshold = 35
elseif bpm >= 120 then
    baseThreshold = 40
end

for i = baseThreshold, 1000, baseThreshold do
    table.insert(milestones, i)
end

-- Always include every 100 combos as special milestones
for i = 100, 1000, 100 do
    table.insert(milestones, i)
end

return milestones

end

local comboThresholds = getComboThresholds(bpm)

-- Function to determine cheering thresholds based on BPM
local function getCheeringThresholds(bpm)
local milestones = {}
local baseCheeringThreshold = 75

if bpm >= 200 then
    baseCheeringThreshold = 45
elseif bpm >= 180 then
    baseCheeringThreshold = 50
elseif bpm >= 160 then
    baseCheeringThreshold = 60
elseif bpm >= 140 then
    baseCheeringThreshold = 70
elseif bpm >= 120 then
    baseCheeringThreshold = 75
else
    baseCheeringThreshold = 85
end

for i = baseCheeringThreshold, 1000, baseCheeringThreshold do
    table.insert(milestones, i)
end

return milestones

end

local cheeringThresholds = getCheeringThresholds(bpm)

-- Function to determine time thresholds based on song length
local function getTimeThresholds(songLength)
local baseThreshold = 30
local milestones = {}

for i = 1, math.floor(songLength / baseThreshold) do
    local milestone = baseThreshold * i
    table.insert(milestones, milestone)
end

return milestones

end

local timeThresholds = getTimeThresholds(songLength)

-- Custom announcer lines for specific combo milestones and time intervals
t[#t+1] = Def.ActorFrame{
ComboChangedMessageCommand=function(self, params)
local combo = params.PlayerStageStats:GetCurrentCombo()
local maxCombo = params.PlayerStageStats.GetMaxCombo and params.PlayerStageStats:GetMaxCombo() or 0
local songPosition = GAMESTATE:GetSongPosition()
local currentTime = songPosition:GetMusicSeconds()

    -- Handle special milestones for 100 - 1000 combos (always play these)
    if combo > 0 and combo % 100 == 0 and lastComboMilestonePlayed ~= combo then
        SOUND:PlayAnnouncer("combo_" .. combo)
        lastComboMilestonePlayed = combo
        return
    end

    if combo > 0 then
        -- Check combo milestones
        if not soundPlaying then
            for _, milestone in ipairs(comboThresholds) do
                if combo == milestone and lastComboMilestonePlayed ~= combo then
                    if combo % 100 ~= 0 then -- Skip special milestones
                        SOUND:PlayAnnouncer("combo_50")
                    end
                    lastComboMilestonePlayed = combo
                    soundPlaying = true
                    self:sleep(comboCooldown):queuecommand("ResetSoundFlag")
                    return
                end
            end

            -- Check cheering milestones if no combo milestone was played
            for _, milestone in ipairs(cheeringThresholds) do
                if combo == milestone and lastCheeringComboPlayed ~= combo then
                    SOUND:PlayAnnouncer("cheering")
                    lastCheeringComboPlayed = combo
                    soundPlaying = true
                    self:sleep(cheeringCooldown):queuecommand("ResetSoundFlag")
                    return
                end
            end
        end
    end

    -- Handle combo break and adjust for song length
    if combo == 0 and maxCombo > 0 and not soundPlaying then
        lastComboMilestonePlayed = 0
        lastCheeringComboPlayed = 0
        
        -- Adjust for song length if combo is broken before 50 combos
        if maxCombo < 50 then
            local elapsedTimeRatio = maxCombo / 50
            local expectedMilestoneTime = songLength * elapsedTimeRatio
            if currentTime >= expectedMilestoneTime then
                SOUND:PlayAnnouncer("combo_50")
                soundPlaying = true
                self:sleep(comboCooldown):queuecommand("ResetSoundFlag")
                return
            end
        end
        
        -- Make the announcer catch up based on song timing
        for _, milestone in ipairs(timeThresholds) do
            if math.floor(currentTime) == milestone and lastTimeMilestonePlayed ~= milestone then
                SOUND:PlayAnnouncer("time_interval_" .. milestone)
                lastTimeMilestonePlayed = milestone
                soundPlaying = true
                self:sleep(comboCooldown):queuecommand("ResetSoundFlag")
                return
            end
        end
    end
end,
ResetSoundFlagCommand=function(self)
    soundPlaying = false
end

}

return t

[makoflagkk]

New updated code local t = Def.ActorFrame{}
local soundPlaying = false
local lastComboMilestonePlayed = 0
local lastCheeringComboPlayed = 0
local lastTimeMilestonePlayed = 0
local firstBPMComboPlayed = false -- Flag to ensure the first BPM-based milestone is a combo
local lastFixedComboMilestonePlayed = 0 -- Track the last fixed 50 combo milestone played
local firstStepMade = false -- Flag to check if the first step is made
local overlapWindow = 5 -- Minimum interval in seconds between different types of milestones
local lastSoundType = nil -- Track the type of the last sound played

local soundTypes = {"combo_50", "cheering"} -- Sound types to alternate
local soundIndex = 1 -- Index to track the current sound type

for pn in ivalues(GAMESTATE:GetHumanPlayers()) do
t[#t+1] = LoadActor("FullCombo", pn)
end

t[#t+1] = LoadActor("GameOver")

local currentSong = GAMESTATE:GetCurrentSong()
local bpm = currentSong and currentSong:GetDisplayBpms()[2] or 120 -- Default BPM if currentSong is nil
local songLength = currentSong and currentSong:GetLastSecond() or 180 -- Default length if currentSong is nil

if currentSong and currentSong:GetDisplayFullTitle() == "LET'S CHECK YOUR LEVEL!" then
t[#t+1] = LoadActor("LET'S CHECK YOUR LEVEL!")
elseif currentSong and currentSong:GetDisplayFullTitle() == "Lesson by DJ" then
t[#t+1] = LoadActor("Lesson by DJ")
end

-- Calculate cooldowns based on BPM
local function getCooldown(bpm)
if bpm >= 200 then
return 10
elseif bpm >= 180 then
return 8
elseif bpm >= 160 then
return 6
elseif bpm >= 140 then
return 4
elseif bpm >= 120 then
return 3
else
return 2
end
end

local comboCooldown = getCooldown(bpm)
local cheeringCooldown = getCooldown(bpm)

-- Function to determine combo thresholds based on BPM
local function getComboThresholds(bpm)
local milestones = {}
local baseThreshold = 50

if bpm >= 200 then
    baseThreshold = 20
elseif bpm >= 180 then
    baseThreshold = 25
elseif bpm >= 160 then
    baseThreshold = 30
elseif bpm >= 140 then
    baseThreshold = 35
elseif bpm >= 120 then
    baseThreshold = 40
else
    baseThreshold = 45
end

for i = baseThreshold, 1000, baseThreshold do
    table.insert(milestones, i)
end

-- Always include every 100 combos as special milestones
for i = 100, 1000, 100 do
    table.insert(milestones, i)
end

return milestones

end

local comboThresholds = getComboThresholds(bpm)

-- Function to determine cheering thresholds based on BPM
local function getCheeringThresholds(bpm)
local milestones = {}
local baseCheeringThreshold = 75

if bpm >= 200 then
    baseCheeringThreshold = 45
elseif bpm >= 180 then
    baseCheeringThreshold = 50
elseif bpm >= 160 then
    baseCheeringThreshold = 60
elseif bpm >= 140 then
    baseCheeringThreshold = 70
elseif bpm >= 120 then
    baseCheeringThreshold = 75
else
    baseCheeringThreshold = 85
end

for i = baseCheeringThreshold, 1000, baseCheeringThreshold do
    table.insert(milestones, i)
end

return milestones

end

local cheeringThresholds = getCheeringThresholds(bpm)

-- Function to determine time thresholds based on song length
local function getTimeThresholds(songLength)
local baseThreshold = 30
local milestones = {}

for i = 1, math.floor(songLength / baseThreshold) do
    local milestone = baseThreshold * i
    table.insert(milestones, milestone)
end

return milestones

end

local timeThresholds = getTimeThresholds(songLength)

-- Function to play the next sound type
local function playNextSoundType()
local soundToPlay = soundTypes[soundIndex]
SOUND:PlayAnnouncer(soundToPlay)
lastSoundType = soundToPlay
soundIndex = soundIndex % #soundTypes + 1
end

-- Custom announcer lines for specific combo milestones and time intervals
t[#t+1] = Def.ActorFrame{
ComboChangedMessageCommand=function(self, params)
local combo = params.PlayerStageStats:GetCurrentCombo()
local maxCombo = params.PlayerStageStats.GetMaxCombo and params.PlayerStageStats:GetMaxCombo() or 0
local songPosition = GAMESTATE:GetSongPosition()
local currentTime = songPosition:GetMusicSeconds()

    -- Check if the first step is made
    if combo > 0 then
        firstStepMade = true
    end

    -- Prevent announcer from playing before the first step is made
    if not firstStepMade then
        return
    end

    -- Handle special milestones for 100 - 1000 combos (always play these)
    if combo > 0 and combo % 100 == 0 and lastComboMilestonePlayed ~= combo then
        SOUND:PlayAnnouncer("combo_" .. combo)
        lastComboMilestonePlayed = combo
        lastSoundType = "combo"
        return
    end

    if combo > 0 then
        -- Check fixed 50 combo milestones first (not divisible by 100)
        if combo % 50 == 0 and combo % 100 ~= 0 and lastFixedComboMilestonePlayed ~= combo then
            -- Check if this is also a BPM-based milestone within the overlap interval
            local isBPMMilestone = false
            for _, milestone in ipairs(comboThresholds) do
                if math.abs(combo - milestone) <= overlapWindow then
                    isBPMMilestone = true
                    break
                end
            end

            -- Skip the fixed 50 milestone if there is an overlap
            if isBPMMilestone then
                return
            end

            SOUND:PlayAnnouncer("combo_50")
            lastFixedComboMilestonePlayed = combo
            soundPlaying = true
            lastSoundType = "combo"
            self:sleep(comboCooldown):queuecommand("ResetSoundFlag")
            if bpm >= 160 then
                self:sleep(comboCooldown):queuecommand("ResetSoundFlag")
            end
            return
        end

        -- Check BPM-based combo milestones
        if not soundPlaying then
            for _, milestone in ipairs(comboThresholds) do
                if combo == milestone and lastComboMilestonePlayed ~= combo then
                    if combo % 100 ~= 0 then -- Skip special milestones
                        if not firstBPMComboPlayed then
                            SOUND:PlayAnnouncer("combo_50")
                            firstBPMComboPlayed = true
                            lastSoundType = "combo"
                            print("Playing first BPM-based combo_50")
                        else
                            playNextSoundType()
                            print("Playing BPM-based sound")
                        end
                    end
                    lastComboMilestonePlayed = combo
                    soundPlaying = true
                    self:sleep(comboCooldown):queuecommand("ResetSoundFlag")
                    if bpm >= 160 then
                        self:sleep(comboCooldown):queuecommand("ResetSoundFlag")
                    end
                    return
                end
            end

            -- Check BPM-based cheering milestones
            if lastSoundType ~= "cheering" then -- Ensure cheering does not play consecutively
                for _, milestone in ipairs(cheeringThresholds) do
                    if combo == milestone and lastCheeringComboPlayed ~= combo then
                        playNextSoundType()
                        lastCheeringComboPlayed = combo
                        soundPlaying = true
                        self:sleep(cheeringCooldown):queuecommand("ResetSoundFlag")
                        if bpm >= 160 then
                            self:sleep(cheeringCooldown):queuecommand("ResetSoundFlag")
                        end
                        return
                    end
                end
            end
        end
    end

    -- Handle combo break and ensure fixed 50 combo milestone still goes off
    if combo == 0 and not soundPlaying then
        if maxCombo > 0 and maxCombo < 50 then
            SOUND:PlayAnnouncer("combo_50")
            soundPlaying = true
            lastSoundType = "combo"
            self:sleep(comboCooldown):queuecommand("ResetSoundFlag")
            if bpm >= 160 then
                self:sleep(comboCooldown):queuecommand("ResetSoundFlag")
            end
            return
        end

        lastComboMilestonePlayed = 0
        lastCheeringComboPlayed = 0
        lastFixedComboMilestonePlayed = 0
        firstBPMComboPlayed = false
        firstBPMCheeringPlayed = false

        -- Adjust for song length if combo is broken before 50 combos
        if maxCombo < 50 then
            local elapsedTimeRatio = maxCombo / 50
            local expectedMilestoneTime = songLength * elapsedTimeRatio
            if currentTime >= expectedMilestoneTime then
                SOUND:PlayAnnouncer("combo_50")
                soundPlaying = true
                lastSoundType = "combo"
                self:sleep(comboCooldown):queuecommand("ResetSoundFlag")
                if bpm >= 160 then
                    self:sleep(comboCooldown):queuecommand("ResetSoundFlag")
                end
                return
            end
        end
        
        -- Make the announcer catch up based on song timing
        for _, milestone in ipairs(timeThresholds) do
            if math.floor(currentTime) == milestone and lastTimeMilestonePlayed ~= milestone then
                SOUND:PlayAnnouncer("time_interval_" .. milestone)
                lastTimeMilestonePlayed = milestone
                soundPlaying = true
                lastSoundType = "time_interval"
                self:sleep(comboCooldown):queuecommand("ResetSoundFlag")
                if bpm >= 160 then
                    self:sleep(comboCooldown):queuecommand("ResetSoundFlag")
                end
                return
            end
        end
    end
end,
ResetSoundFlagCommand=function(self)
    soundPlaying = false
end

}

return t