Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[YouTube] Channel handles url does not work without @ prefix. #9436

Open
6 tasks done
Cryptophunk opened this issue Nov 20, 2022 · 5 comments
Open
6 tasks done

[YouTube] Channel handles url does not work without @ prefix. #9436

Cryptophunk opened this issue Nov 20, 2022 · 5 comments
Labels
feature request Issue is related to a feature in the app youtube Service, https://www.youtube.com/

Comments

@Cryptophunk
Copy link

Cryptophunk commented Nov 20, 2022

Checklist

  • I am able to reproduce the bug with the latest version.
  • I made sure that there are no existing issues - open or closed - which I could contribute my information to.
  • I have read the FAQ and my problem isn't listed.
  • I have taken the time to fill in all the required details. I understand that the bug report will be dismissed otherwise.
  • This issue contains only one bug.
  • I have read and understood the contribution guidelines.

Affected version

0.24.1

Steps to reproduce the bug

  1. In Firefox (not chrome as it wants you to use/install the YouTube app to open in-app) go to a channel that has a channel handle but remove the @ prefix. For example https://www.youtube.com/CharlieSolis
  2. If you have Newpipe configured to open up YouTube associated links automatically you can confirm it works by adding the @ prefix eg https://www.youtube.com/@CharlieSolis

Expected behavior

Newpipe should launch to the respected channel page associated with the url. It does not do this behaviour without adding the @ prefix.

Actual behavior

App does not respond.

Screenshots/Screen recordings

No response

Logs

No response

Affected Android/Custom ROM version

Android 10

Affected device model

All Models

Additional information

No response

@Cryptophunk Cryptophunk added bug Issue is related to a bug needs triage Issue is not yet ready for PR authors to take up labels Nov 20, 2022
@opusforlife2 opusforlife2 added feature request Issue is related to a feature in the app youtube Service, https://www.youtube.com/ and removed bug Issue is related to a bug needs triage Issue is not yet ready for PR authors to take up labels Nov 20, 2022
@Cryptophunk
Copy link
Author

Cryptophunk commented Nov 22, 2022

@opusforlife2 isn't this a bug because the pull request "[YouTube] Support handles and all channel usernames #964" indicates that all channel usernames and handles are now supported?

@opusforlife2
Copy link
Collaborator

It doesn't matter what a pull request says. Since this isn't part of the current release (0.24.1) and it makes no claim to support handles, this is a new feature that is being perfected. You could have 10 PRs which add support for a feature in small chunks, and sometimes break and fix things in the process as well.

@Cryptophunk
Copy link
Author

@opusforlife2 are you sure you checked to make sure that this was included in 0.24.1? In the blog post for this update it says this:
"@AudricV added support for YouTube handles. This refers to channel links starting with ‘@’. Also, more kinds of usernames are supported now."

It also mentions this new feature in the release notes for 0.24.1

@opusforlife2
Copy link
Collaborator

You're right, my bad. I thought the PR was merged after the release.

@opusforlife2 opusforlife2 added bug Issue is related to a bug and removed feature request Issue is related to a feature in the app labels Dec 3, 2022
@Cryptophunk
Copy link
Author

Cryptophunk commented Dec 4, 2022

I don't have an environment set up to test this but would adding
<data android:pathPrefix="/" /> under line 156 found here fix the issue?
Maybe this is something @AudricV can answer and test for me. Thanks so much in advance!

@ShareASmile ShareASmile added feature request Issue is related to a feature in the app and removed bug Issue is related to a bug labels Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Issue is related to a feature in the app youtube Service, https://www.youtube.com/
Projects
None yet
Development

No branches or pull requests

3 participants