Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

What to do with NotificationUtils? #8891

Closed
opusforlife2 opened this issue Aug 27, 2022 · 2 comments
Closed

What to do with NotificationUtils? #8891

opusforlife2 opened this issue Aug 27, 2022 · 2 comments
Labels
codequality Improvements to the codebase to improve the code quality discussion This needs to be discussed before anything is done

Comments

@opusforlife2
Copy link
Collaborator

From the OP:

Maybe we could merge it with NotificationUtil? Tell me what you think

This might have been addressed in the review comments, but just in case it wasn't, I'm leaving this here for future reference.

Originally posted by @opusforlife2 in #8170 (comment)
@opusforlife2 opusforlife2 added discussion This needs to be discussed before anything is done codequality Improvements to the codebase to improve the code quality labels Aug 27, 2022
@Stypox
Copy link
Member

Stypox commented Aug 27, 2022

I think this does not need its own issue. Just put it into the things-to-be-refactored-of-the-player issue

@opusforlife2 opusforlife2 closed this as not planned Won't fix, can't repro, duplicate, stale Aug 27, 2022
@opusforlife2
Copy link
Collaborator Author

Added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
codequality Improvements to the codebase to improve the code quality discussion This needs to be discussed before anything is done
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Stypox @opusforlife2