Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Make compatible with "Share" option from Shazam to open videos #868

Open
2 tasks done
ghost opened this issue Nov 21, 2017 · 7 comments
Open
2 tasks done
Labels
feature request Issue is related to a feature in the app

Comments

@ghost
Copy link

ghost commented Nov 21, 2017

  • I checked if the issue/feature exists in the latest version.
  • I carefully read the contribution guidelines and agree to them.

Shazam has been unfortuantely embedding their stupid videos within shazam itself as a youtube player. If i click the share option to open the video link with NewPipe it wont open, i assume because you would need to somehow truncate the shazam part of the link and be able to open the video in NewPipe as a youtube URL, can you do this please? Would be a timesaver. thanks

@ghost
Copy link
Author

ghost commented Nov 21, 2017

Or if there is an easier way to open shazam youtube links in NewPipe then please share your idea and make it work :)

@ghost ghost changed the title Make compatible with "Share" option from Shazam to open videos [Feature] Make compatible with "Share" option from Shazam to open videos Nov 21, 2017
@theScrabi
Copy link
Member

Could you please post such a shazam link.

@ghost
Copy link
Author

ghost commented Nov 22, 2017

Sorry @theScrabi, i misread. The shazam link does not have a youtube link within it. Would it be possible to be able to open a shazam video into NewPipe using Artist+Title within the share link:
When you click 'share' in shazam and you share it with 'Messenger' the link it shares will be eg.
"I used Shazam to discover Slappin by E-40 Feat. Nef The Pharaoh & D.R.A.M.. https://www.shazam.com/track/311596721/slappin"

Configure to open with NewPipe using something like:
https://www.youtube.com/results?search_query=Slappin+by+E-40+Feat.+Nef+The+Pharaoh+%26+D.R.A.M

Not sure if this is the best method to integrate shazam again to be able to use with NewPipe. It used to work before shazam embedded their own youtube player.

@theScrabi
Copy link
Member

I see. We'd have to update RouterActivity in order to allow open url's with search query.

@ghost
Copy link
Author

ghost commented Nov 22, 2017

oh ok, I personally dont have much programming experience.. would appreciate it if you could do this though, thanks in advance.

@SpajicM
Copy link
Contributor

SpajicM commented Nov 25, 2017

I can look into it.

@theScrabi we'd also need to make SearchUrlHandler, right?

@stale

This comment was marked as resolved.

@stale stale bot added the stale label Dec 1, 2018
@Stypox Stypox added feature request Issue is related to a feature in the app help wanted Help is wanted in fixing this issue and removed help wanted Help is wanted in fixing this issue labels Jun 23, 2019
@TobiGr TobiGr removed the stale label Jul 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Issue is related to a feature in the app
Projects
None yet
Development

No branches or pull requests

4 participants