Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Invidious and Piped instances #8502

Open
5 tasks done
opusforlife2 opened this issue Jun 11, 2022 · 8 comments
Open
5 tasks done

Update Invidious and Piped instances #8502

opusforlife2 opened this issue Jun 11, 2022 · 8 comments
Labels
feature request Issue is related to a feature in the app

Comments

@opusforlife2
Copy link
Collaborator

Checklist

  • I made sure that there are no existing issues - open or closed - which I could contribute my information to.
  • I'm aware that this is a request for NewPipe itself and that requests for adding a new service need to be made at NewPipeExtractor.
  • I have taken the time to fill in all the required details. I understand that the feature request will be dismissed otherwise.
  • This issue contains only one feature request.
  • I have read and understood the contribution guidelines.

Feature description

It's been a long time since the list of instances in the manifest was updated. The list has changed a lot since then.

Why do you want this feature?

New instances can be used with Newpipe.

Additional information

Should old instances be deleted from the list? I was wondering about this. Users might come across links to now-defunct instances. I see no issue with these links opening in Newpipe, since the domain is discarded, anyway.

So maybe the list should contain all previous and current instances for maximum link compatibility.

@opusforlife2 opusforlife2 added the feature request Issue is related to a feature in the app label Jun 11, 2022
@markusgerber76
Copy link

Where is the UI for piped? How does one add a piped instance?

@triallax
Copy link
Contributor

@markusgerber76 are you interested in fixing this issue? If so, I'll assign you to it.

To answer your question, here's the Piped repo, and here's the instances list. Piped instances are added to app/src/main/AndroidManifest.xml and also in the extractor. See #6557 and TeamNewPipe/NewPipeExtractor#668 for an example of how this is done.

Should old instances be deleted from the list? I was wondering about this. Users might come across links to now-defunct instances. I see no issue with these links opening in Newpipe, since the domain is discarded, anyway.

So maybe the list should contain all previous and current instances for maximum link compatibility.

I agree with everything you say.

@triallax triallax added the good first issue Easy/simple issues perfect for newcomers to get involved in the project label Jun 15, 2022
@litetex litetex removed the good first issue Easy/simple issues perfect for newcomers to get involved in the project label Jun 19, 2022
@litetex
Copy link
Member

litetex commented Jun 19, 2022

I wouldn't recommend updating the list:

  1. There is currently work done on Add Invidious support #8220
  2. We shouldn't use a hardcoded list of instances, because it's impossible to keep up with updating ;)

@triallax
Copy link
Contributor

here is currently work done on #8220

We don't know when that might be merged. Also, it doesn't apply to Piped instances.

We shouldn't use a hardcoded list of instances, because it's impossible to keep up with updating ;)

What do you propose then?

@litetex
Copy link
Member

litetex commented Jun 19, 2022

I think we should fix this in the long run by doing 2 things:

  1. Support Intent interception for all links #7456 - This fixes the hardcoded entries inside the Android manifest file
  2. Keep a user-editable list of known instances (Noted that already inside Add Invidious support #8220 - but we may also open a new issue) - This fixes the hardcoded entries inside the NewPipe extractor

Maybe in the short term we can update them but that's definitely not a future proof solution.

@opusforlife2
Copy link
Collaborator Author

Isn't intent handling extremely limited Android 12 onwards?

@opusforlife2
Copy link
Collaborator Author

We can probably copy a list of the latest working instances off of Libredirect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Issue is related to a feature in the app
Projects
None yet
Development

No branches or pull requests

5 participants
@triallax @litetex @markusgerber76 @opusforlife2 and others