Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch ActivityNotFoundException (file-manager) and display a meaningful error #7113

Closed
3 tasks done
litetex opened this issue Sep 15, 2021 · 0 comments · Fixed by #7452
Closed
3 tasks done

Catch ActivityNotFoundException (file-manager) and display a meaningful error #7113

litetex opened this issue Sep 15, 2021 · 0 comments · Fixed by #7452
Assignees
Labels
feature request Issue is related to a feature in the app

Comments

@litetex
Copy link
Member

litetex commented Sep 15, 2021

Checklist

Describe the feature you want

There are currently many issues that say that an file-manager - that should be shipped by a "standard" android - is missing:
https://github.com/TeamNewPipe/NewPipe/search?o=desc&q=No+Activity+found+to+handle+Intent&s=created&type=issues

This is usually due to incomplete custom ROMs or because the user uninstalled it's file-manager.

Background: It reached my tipping-point when I got 2 new comment-notifications in #7076 within 12h as some people seem too be unable to read properly what I wrote a few comments above or search for the error.

Also sometimes the ACRA report seems to fail: #7076 (comment)

Anyway the missing file-manager usually results in a ActivityNotFoundException, e.g:

  • android.content.ActivityNotFoundException: No Activity found to handle Intent { act=android.intent.action.OPEN_DOCUMENT cat=[android.intent.category.OPENABLE] typ=*/* flg=0x43 (has extras) }
  • android.content.ActivityNotFoundException: No Activity found to handle Intent { act=android.intent.action.CREATE_DOCUMENT cat=[android.intent.category.OPENABLE] typ=application/zip flg=0x43 (has extras) }

It would be great if we could catch exceptions like those and show a dialog/toast that says something like "Unable to open file-manager... Is one installed?".
A simple try catch on certain code blocks should be enough 😄

Is your feature request related to a problem? Please describe it

https://github.com/TeamNewPipe/NewPipe/search?o=desc&q=No+Activity+found+to+handle+Intent&s=created&type=issues

How will you/everyone benefit from this feature?

Devs/Mods: Less issues that can have to investigated and closed as duplicates
Users: Faster knowledge of what causes the error → can fix it themselves

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Issue is related to a feature in the app
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant