Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 0.21.7 Broke Subscriptions Page Condensed Grid Layout #6802

Closed
4 tasks done
desmonk opened this issue Jul 29, 2021 · 8 comments · Fixed by #6814
Closed
4 tasks done

Version 0.21.7 Broke Subscriptions Page Condensed Grid Layout #6802

desmonk opened this issue Jul 29, 2021 · 8 comments · Fixed by #6814
Labels
bug Issue is related to a bug GUI Issue is related to the graphical user interface

Comments

@desmonk
Copy link

desmonk commented Jul 29, 2021

Checklist

Steps to reproduce the bug

Recent update 0.21.7 made grid layout of "Subscriptions" page less condensed somehow. Attached screenshots are both in portrait mode and yet you can see the visible change

Actual behavior

Same as prior.

Expected behavior

Should remain unchanged.

Screenshots/Screen recordings

IMG_000008
IMG_000009

Logs

NA

Device info

  • Android version/Custom ROM version: 11
  • Device model: OnePlus
@desmonk desmonk added the bug Issue is related to a bug label Jul 29, 2021
@triallax triallax added the GUI Issue is related to the graphical user interface label Jul 30, 2021
@triallax
Copy link
Contributor

I believe the only grid-related PR merged in 0.21.7 is #6705. If I'm right about this, I expect https://github.com/TeamNewPipe/NewPipe/suites/3277311604/artifacts/76378391 (the APK for the commit right before the PR merge commit) to not have the issue, but https://github.com/TeamNewPipe/NewPipe/suites/3276913491/artifacts/76366095 should have it. Can you test this?

@desmonk
Copy link
Author

desmonk commented Jul 30, 2021

Yes, that is correct.

@triallax
Copy link
Contributor

@Stypox any ideas?

@Stypox
Copy link
Member

Stypox commented Aug 1, 2021

@desmonk could you test #6814?

@desmonk
Copy link
Author

desmonk commented Aug 2, 2021

Yes, that did solve it!

@desmonk desmonk closed this as completed Aug 2, 2021
@triallax
Copy link
Contributor

triallax commented Aug 2, 2021

The PR has not been merged yet, so please keep this issue open.

@triallax triallax reopened this Aug 2, 2021
@desmonk
Copy link
Author

desmonk commented Aug 2, 2021

Alright.

Update: Version 0.21.8 - Same Problem

@triallax
Copy link
Contributor

triallax commented Aug 19, 2021

The PR was merged, so closing this.

Update: Version 0.21.8 - Same Problem

The PR was not included in 0.21.8. It will be in 0.21.9 though. Please test the APK in #6841.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue is related to a bug GUI Issue is related to the graphical user interface
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants