Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for improved 144p #613

Closed
phly95 opened this issue Jul 7, 2017 · 9 comments
Closed

Support for improved 144p #613

phly95 opened this issue Jul 7, 2017 · 9 comments
Labels
discussion This needs to be discussed before anything is done

Comments

@phly95
Copy link

phly95 commented Jul 7, 2017

  • [y] I carefully read the contribution guidelines and agree to them.
  • [y] I checked if the issue/feature exists in the latest version.

It seems you use the flip-phone version of youtube's 144p (3GPP), however, youtube has improved compression and offers much better looking 144p (not sure about bitrates though, but compare 144p in newpipe compared to 144p on youtube's website). It would be nice if you offered the improved codec version along with a choice in audio bitrate for people who are data constrained (16-64k audio would work), but would like better video quality.

A compression server that converts to 16k opus would be cool, but I'm sure that would require too many resources on the newpipe server, unless youtube already offers it.

@utack
Copy link

utack commented Jul 10, 2017

There is a "ready to go" muxed version, which is really sh*t
You probably mean this one with the "flip phone" version:
17 3gp 176x144 small , mp4v.20.3, mp4a.40.2@ 24k

Other 144p options are video to choose from as separate stream
278 webm 256x144 144p 118k , webm container, vp9, 30fps, video only
160 mp4 256x144 DASH video 133k , avc1.4d400c, 30fps, video only
330 webm 256x144 144p60 204k , vp9.2, 60fps, video only

and two small audio versions that might go with it
139 m4a audio only DASH audio 48k , m4a_dash container, mp4a.40.5@ 48k (22050Hz)
249 webm audio only DASH audio 59k , opus @ 50k

Example video
"flip phone 144p": 3.2MB
10fps and mono audio
mpv-shot0034

"diy 144p" vp9+50k opus: 6.2MB
30fps and stereo audio
mpv-shot0035

It probably makes sense to choose the 30fps vp9 and the smallest opus audio, as any phone out there can decode vp9 at such low resolution in software and quality is immensely better than the "flip phone version"
But it is also roughly twice the size, which can add up quickly for people who really want the absolutely lowest file size to stream

@mauriciocolli mauriciocolli added the discussion This needs to be discussed before anything is done label Jul 10, 2017
@mauriciocolli
Copy link
Contributor

mauriciocolli commented Jul 10, 2017

The thing is, opus is supported only in Android 5.0+ (from android official guide), there are extensions for playing opus in every device (in ExoPlayer), but I really don't want to include it in the app, as it'll requires native code.

Currently, the chosen audio stream that we play together with a video only stream, is the one that matches the preferred format (in the settings) and have the highest bit rate available.

And some videos have the 139 stream (a very low quality audio m4a), I'm thinking in using it when the user selects such low qualities (144p), but that is just an idea for now.

@utack
Copy link

utack commented Jul 10, 2017

@mauriciocolli sorry to hijack this issue, but does "webm" use opus on devices that support opus playback or always vorbis?

@mauriciocolli
Copy link
Contributor

@utack no it doesn't (you can see the list here), but I was thinking in doing that.

@utack
Copy link

utack commented Jul 10, 2017

would be nice, since lately it is not just the better codec, but also getting more bitrate than AAC as well

@phly95
Copy link
Author

phly95 commented Jul 11, 2017

Huh, 144p60 is an option. That would be a very interesting combination to see in action. I wonder if it would be possible to use the 24k m4a stream along with these interesting resolutions. Maybe quality needs to be a nested menu where you select video quality > FPS > Format > Audio format > bitrate . The issue with offering this much choice however could mean confusing both the users and developers though, so I'm not quite sure how viable that would be.

@stale
Copy link

stale bot commented Dec 1, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Dec 1, 2018
@ghost
Copy link

ghost commented Jan 25, 2019

Close this issue.

@TobiGr TobiGr removed the stale label Jul 19, 2019
@opusforlife2
Copy link
Collaborator

Already added.

@Stypox Stypox closed this as completed Aug 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion This needs to be discussed before anything is done
Projects
None yet
Development

No branches or pull requests

6 participants