Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show copy link and other sharing options in one page just like YouTube app #5784

Closed
3 tasks done
SameenAhnaf opened this issue Mar 7, 2021 · 4 comments
Closed
3 tasks done
Labels
feature request Issue is related to a feature in the app GUI Issue is related to the graphical user interface

Comments

@SameenAhnaf
Copy link
Collaborator

SameenAhnaf commented Mar 7, 2021

Checklist

Describe the feature you want

My smartphone shows sharing apps in four rows. It's irritating as I often need to swipe from left to right for three or two times. It would be great if Newpipe had the ability to show sharing options within a single page

And, yes, "Copy Link" option should be added. I can't mention any link while browsing any website.

Is your feature request related to a problem? Please describe it

Additional context

IMG_20210307_134941

How will you/everyone benefit from this feature?

@SameenAhnaf SameenAhnaf added the feature request Issue is related to a feature in the app label Mar 7, 2021
@SameenAhnaf SameenAhnaf changed the title Show sharing apps in one page just like YouTube app Show copy link and other sharing options in one page just like YouTube app Mar 7, 2021
@triallax
Copy link
Contributor

triallax commented Mar 8, 2021

If I'm not mistake, YouTube uses its own custom share sheet. I'm not sure if we want to do that, as we might be removing some functionality of the default share sheet (which differs between Android systems and ROMs).

@triallax triallax added the GUI Issue is related to the graphical user interface label Mar 8, 2021
@SameenAhnaf
Copy link
Collaborator Author

@mhmdanas I think, that would not be a problem. An option in the settings can be kept as "Show sharing options". Options could be kept "From system page" and "From Newpipe page".

@AudricV
Copy link
Member

AudricV commented Mar 14, 2021

@SameenAhnaf I already worked on this (see PR #5187) but your ROM due to OEMs customizations doesn't keep the option, like on EMUI too (even if now the share sheet after my PR is now from Android System Chooser and not Huawei System Chooser on EMUI devices).
Your idea to have an option to display a custom share sheet or not is a really good idea! I think if we implement a custom share sheet, we should take the Android stock design.
The negative aspect of this custom share sheet is that user can't select quick actions, like a contact or a people in social networks, because apps cannot access to them if I am not wrong. This is what @mhmdanas says above.

For now, you can install Share to Clipboard, available in F-Droid: https://f-droid.org/packages/com.tengu.sharetoclipboard/, and remove copying the extra subjects (like the title of a stream) in app settings. This is what I do myself because most of other apps got the Huawei Share Sheet instead of Android Share Sheet (by using the Android standard method for create choosers of intents, Intent.createChooser(), instead of using an ACTION_CHOOSER intent, see the PR for more details).

@SameenAhnaf
Copy link
Collaborator Author

@TiA4f8R Thanks for your valuable explanation and Share to Clipboard app link.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Issue is related to a feature in the app GUI Issue is related to the graphical user interface
Projects
None yet
Development

No branches or pull requests

3 participants