Opening some types of URLs cause permanent buffering

[Timsonrobl]

Checklist

• I am using the latest version - 0.20.6
• I checked, but didn't find any duplicates (open OR closed) of this issue in the repo.
• I have read the contribution guidelines given at https://github.com/TeamNewPipe/NewPipe/blob/HEAD/.github/CONTRIBUTING.md.
• This issue contains only one bug. I will open one issue for every bug report I want to file.

Steps to reproduce the bug

1. Go to youtu.be link for a video inside playlist with a time code. Example 'https://youtu.be/ut3n8-9JM5o?list=PLbQ-gSLYQEc4mnWapHJd0K-sPvLcEwOSS&t=274'
   Such URLs are provided when you click RMB in web YouTube player and choose "Copy video URL at current time"

Actual behaviour

Infinite buffering on black screen.

Expected behavior

Opening video on specified time.

Device info

• Android version/Custom ROM version: 8.0
• Device model: Samsung Galaxy S7

[tiwarys]

I'm also facing this issue.

[XiangRongLin]

This issue is not limited to videos inside playlists. I think any video with an timestamp will cause this issue
ex.: https://www.youtube.com/watch?v=nSNQ_Qh9Pss&t=203

@Stypox @TobiGr
This is an regression from 19.8 to 20.8, because in pre unified version the link in the top comment and mine above work.

The reason for the endless buffering is that the playQueue is null and BasePlayer.onPlay() just silently returns without doing anything

NewPipe/app/src/main/java/org/schabi/newpipe/player/BasePlayer.java

Lines 1128 to 1134 in 8fe1a76

	public void onPlay() {
	if (DEBUG) {
	Log.d(TAG, "onPlay() called");
	}
	if (audioReactor == null || playQueue == null || simpleExoPlayer == null) {
	return;
	}

Reason for playQueue being null is that item.getRecoveryPosition() returns the timestamp, which is not equal PlayQueueItem.RECOVERY_UNSET. This causes initPlayback to never be called, which would set the playQueue. I assume previously videos with timestamps were not handled here, but somewhere else.

NewPipe/app/src/main/java/org/schabi/newpipe/player/BasePlayer.java

Line 348 in 8fe1a76

if (item != null && item.getRecoveryPosition() == PlayQueueItem.RECOVERY_UNSET) {

[XiangRongLin]

@Timsonrobl @shivasagarrao
I opened a PR linked above to adress this, can you test it out

[XiangRongLin]

#5301
this could be related. because it's the same problem of playQueue being null

[tiwarys]

@XiangRongLin I tested the apk and links with start time are loading perfectly now. Thanks for PR.