Regression - Share and other buttons in video details

[opusforlife2]

Version

• 0.20.0

Problem

Now that the unified player PR is merged, let me be the first to add a bug to the Unified Player project (https://github.com/TeamNewPipe/NewPipe/projects/17).

We need to find a way to place the Share button back somewhere on the video details page.

Edit: List of buttons reported to be missing:

• Share
• Resolution selector
• Cast to Kodi

List of other possibly useful buttons:

• Play in external player
• Playback speed
• Fit/Fill/Zoom
• Captions
• Mute
• Open in browser

Solution

My suggestion was that it could be placed next to the Autoplay toggle.

From the discussion below:

• How about a left to right swipeable list where the 4 action buttons are? The default visible actions would be the most used ones, and the lesser used ones could be swiped into view, 4 at a time.
• Better would be to allow to rearrange them via long tap and drag.
• I also think it should show as many buttons as possible on that device, e.g. a tablet in landscape will definitely be able to show more than 4 buttons I think.
• Actually, now that I think about it, that right arrow indicator should be present for all form factors, not just TV. We have to let the user know there is something new there, after all. A right arrow beside the download button would be obvious enough to be noticed. Otherwise mobile users would likely not know about this feature until they accidentally swipe sideways in just the right way or read about the feature online.
• Moreover, once the user has swiped left once to access the next 4 action buttons, we should also show a left arrow indicator next to the first action button, as well.

[avently]

What do you call

Autoplay toggle.

?
And why don't you like current place of share button?

[opusforlife2]

Same as I said here: #2907 (comment)

Basically, we currently have a Share button in the top bar (menu bar?) which is gone now, since the entire bar is gone after your PR. This contained the resolution selector and the share button. Resolution selector isn't that important because using it shows intent to play the video anyway, so you might as well change it after playing the video.

But not having a way to share the link without playing the video first, is a regression. So I suggested to put the Share button here:

I thought you didn't like the idea. Now I get the feeling it was just a communication gap between us. 😆

[avently]

I thought you didn't like the idea. Now I get the feeling it was just a communication gap between us.

I just didn't get in the PR thread what you mean by autoplay toggle:) I didn't even think about that area in the page because it's hidden all the time (comments is visible almost always)

a communication gap between us

The issue with a share button is a gap between us. I use it a couple of times in my life and I don't think it should be visible on the page at. It's not useless but it's unused all the time. So I think the current position is good for an unused element.

Let's say someone will come here and say that he wants to see subtitles, or mute, or scale button near autoplay toggle, what will you say? You'll probably say that it's insane idea because these things are unused. This is how I feelling about share button.

[wb9688]

@avently: I'd like to point out that there is a difference between the in-player share button and the share button that previously was at the top. The latter keeps the original URL, while the later first simplifies the URL and then adds the current timestamp (if possible for that service).

I do agree that next to the autoplay button isn't the right location for it imho.

[avently]

while the later first simplifies the URL and then adds the current timestamp (if possible for that service).

So is there situation when you need the first instead of the second? If so, it is possible to show an AlertDialog with both links. Isn't it the fix?

[opusforlife2]

@avently

subtitles, or mute, or scale button near autoplay toggle

They are in the same situation as the resolution selector. As I said above, you only need these once the video is already playing. But that is not the case with sharing. Having to first play a video before being able to share it doesn't make sense. Here's how it would go:

1. You're on the video details page.
2. You tap on the video to play.
3. Tap again to show player controls UI.
4. Tap on the expansion arrow.

Now it's either:

5. Tap on Share.
6. Select an app to share to.
7. Scrub the timestamp from the URL manually.
8. Send the link.

or, if you implement an AlertDialog:

5. Tap on Share. AlertDialog opens.
6. Select the simple share option.
7. Select an app to share to.
8. Send the link.

Your solution is still the same number of steps, just like before. The only thing it is helping with is that the manual timestamp removal is gone.

On the current release, this is the how it goes:

1. You're on the video details page.
2. Tap on Share.
3. Select an app to share to.
4. Send the link.

See the difference?

As for a counter example, take the resolution selector.
In current release, you can:

1. Select resolution.
2. Play video.

After your PR:

1. Play video at default resolution.
2. Change resolution. Takes a few seconds to load the stream.

That's it. The only addition there is a few seconds. So I don't mind it much.

@wb9688

I do agree that next to the autoplay button isn't the right location for it imho.

Yeah, it's just the first empty space I thought of that didn't seem problematic. Any ideas?

[avently]

Your solution is still the same number of steps

I'm not saying it's for effective than yours in terms of number of steps. But it's better logically (unused thing on unused place).

Any ideas?

I see only only two solutions:

1. add a button on top of a thumbnail (like with three dots icon) in the right corner. So it will be visible only when there is thumbnail shown instead of a player. Not good solution and will not save you a one tap. Also this button can be shown in the bottom left corner after duration.
2. Replace download buttons with something like "Actions" which will present bottom sheet dialog like Youtube do with many actions. This one is better since download button is often unused too.

I don't like both solutions but second one is probalby the way how it should work. Don't forget that there is a open in browser button which should be moved out of player too.

[opusforlife2]

Don't forget that there is a open in browser button which should be moved out of player too.

Actually, I'm not sure why that button exists. You can select your browser from the Share sheet directly.

[opusforlife2]

Replace download buttons with something like "Actions" which will present bottom sheet dialog like Youtube do with many actions. This one is better since download button is often unused too.

Hmm. How about a left to right swipeable list where the 4 action buttons are? The default visible actions would be the most used ones, and the lesser used ones could be swiped into view, 4 at a time. Maybe the buttons could change positions based on frequency of use.

If this is a viable solution, then I think swiping them to view 4 at a time would be better than a loose scrollable list, because tapping on the action buttons could become tedious.

[avently]

The default visible actions would be the most used ones, and the lesser used ones could be swiped into view

That's great solution! Not sure about frequency of use because buttons changing their place is kind of annoying and unexpected. Better would be to allow to rearrange them via long tap and drag. But scrollable list is useful. Not many buttons have to be there. Maybe someone will implement it, I hope so.

[opusforlife2]

Better would be to allow to rearrange them via long tap and drag.

Yeah, that makes more sense.

[B0pol]

Swipe doesn't work with Android TV

[opusforlife2]

Swipe doesn't work with Android TV

An arrow indicator at the right for TV, then? When you reach the rightmost action button, another right arrow command from the remote would scroll ahead.

[wb9688]

@opusforlife2: I'm pretty sure it'll just go to the next button when you press right at the last visible button on TV in the kind of swiping thing you meant.

Edit: I also think it should show as many buttons as possible on that device, e.g. a tablet in landscape will definitely be able to show more than 4 buttons I think.

[opusforlife2]

Oh. Then what about this? When the cursor (box) is on the rightmost action button, another right command would shift the cursor to the right arrow itself. Then it can be clicked on to do the swipe action.

[wb9688]

@opusforlife2: I meant that your initial swiping idea should just work fine out of the box on Android TV, similar to how you could also e.g. just scroll in the search results (but horizontally instead of vertically obviously).

[opusforlife2]

Oh. I thought you meant the cursor would shift to the suggested videos list on the right.

[opusforlife2]

Actually, now that I think about it, that right arrow indicator should be present for all form factors, not just TV. We have to let the user know there is something new there, after all. A right arrow beside the download button would be obvious enough to be noticed. Otherwise mobile users would likely not know about this feature until they accidentally swipe sideways in just the right way or read about the feature online.

Moreover, once the user has swiped left once to access the next 4 action buttons, we should also show a left arrow indicator next to the first action button, as well.

[opusforlife2]

Wow. @XiangRongLin already suggested a scrollable action bar months ago here: #3583 (comment)

[Younes-L]

Hello, I'd like to know why the action bar was removed :(
Thankfully the navigation drawer is finally accessible from the video info screen.

My suggestion is that these action buttons are way, way more important than comments or related videos.
Just push the comments down a 2nd row and put any missing button a 2nd row.
In this such a way there will be no need for additional taps and swipes and clues, as the buttons will be immediately visible.

@opusforlife2 I believe it is now master branch , 0.20.0

[opusforlife2]

Changed. Thanks.

[sanityormadness]

For the record, I use the Share button on the details page all the time after I've finished watching.

Know why? #2277 (First level-only comments are pointless on the vast majority of videos, so I don't even show them in NewPipe.)

[rancidfrog]

Took me a while to find share button.
Only issue is why is there no menu in pop-up player to share?
Full video player

vs
Pop-Up

Is it not possible to have the same implementation in both?
That way there is continuance in design and users will not be confused where to find those buttons

[B0pol]

No, because popup player has less free room for icon

[rancidfrog]

@B0pol

Sorry, that makes no sense
Instead of the full screen icon, the arrow could be used moving full screen below, it takes the same amount of space as the other icons already displayed, it is even smaller.
Or it could be right beside 360p 1x as in first image above

The only issue is if the pop-up is too small, but then how are the other icons handled?

I do not understand what the issue is:
Full player:

Pop-Up player

Clearly there are already icons on display in pop-up player
replacing full screen with arrow or keeping the arrow key in same position as full player - beside 360p 1x ^
should be possible too

[opusforlife2]

@rancidfrog This is off-topic here. Could you open a new issue for this? Thanks.

[rancidfrog]

@opusforlife2
Sure.
But is will just be another issue about share button?

[B0pol]

There is no space here @rancidfrog

And even if theorically there is space, popup player is supposed to be minimalistic and not bloated.

Android's picture in picture mode has only a play / pause button.

[rancidfrog]

@B0pol

You were saying:

Just to bother you.
You see - if you replace full player mode with arrow icon then you can have the same expanding list with share|full screen| etc.

And, this is the smallest pop-up player can go.
So, full-screen will need to be replaced with arrow icon which expands with list of options.

For future comments regarding this issue #4601
As @opusforlife2 suggested since this is his issue after all

This might be a slight design change in regards to the implementation, but it is the same logic.
Since same arrow key will be used, just space issues firces list view

[poutnikl]

I suppose many NP users frequently revisit NP for the video they already know or have. They are not interested in watching, but in fetching the link to this particular video to share.

The very majority of my shares were not from the time I was watching/listening a video, but from later, when I needed the link reference.

If I have to watch video anytime I want its link, it does not make much sense. It is like if I had to download a file from a web site each time I want the link to it.

[rancidfrog]

@poutnikl
An easy way would be to go to history and long-press that video and select share.
But, this works well if you watched video and if it was recently watched.
Otherwise it would be a hassle to scroll through history to find the video.

[poutnikl]

@rancidfrog It may work for video watching. But for many cases, I am only interested in downloading the video, or just the audio part. Often, when fast connection is available, I do not have time or mood to watch/listen and vice versa. Later I may eventually share the YT link for others to watch/listen. This may be even after long time.

I would understand if some devs consider sharing as seldom used function and it's button should not be so exposed, moving it elsewhere. As people have different POV.

But putting it exclusively to the player window is semantically just wrong, as this functionality has nothing to do specifically with the player functionality.

EDIT: There is the share option if you long press on result list item. For strange reasons I missed the last sharing item at the bottom of the context menu previously. I find the lost sharing from details page more handy, but even this is more useful than going to player.

[bunyevacz]

One serious drawback for the current share button location is, that you need to start (and also redownload!!) the video again to be able to access the functionality.

This is my workflow:
I download all the videos - which I want to listen/watch next day during my work - on my home internet connection via wifi at previous evening.

When I want to check the comments, I click on the video in my "downloaded" tab, and "show info". Then I need to start the video, but I'm not on my home internet connection anymore rather on my mobile internet connection which is a scarce resource, and I really need to think twice if I want to watch a video on that connection. 1 GiB data usage is not much for a whole month (in my case).

I think the share button should be accessible without causing a video (re)download.

Sorry for the long explanation and thank you for your time and attention.

[Hund]

Why is this taking so long to fix? It's super annoying that one of the most used feature was removed. :(

[Hund]

Because someone has spent way too much time and effort removing lots of features from 0.20 release. Now someone else has to make a comparable effort to re-implement them.

Why do that with the stable branch though? :)

[opusforlife2]

Why is this taking so long to fix?

@Hund There is a PR linked which you can test and give feedback on.

Why do that with the stable branch though? :)

There is no "stable branch". Newpipe has only one release track.

@nbmrjuhneibkr I'm minimising your comment because of its passive-aggressiveness.

[Stypox]

Go cast your vote at #4534 (comment)

[opusforlife2]

Woohoo! My Share button!