Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Playback speed performance regression. #3493

Closed
ZoomRmc opened this issue Apr 26, 2020 · 5 comments
Closed

Playback speed performance regression. #3493

ZoomRmc opened this issue Apr 26, 2020 · 5 comments
Labels
bug Issue is related to a bug

Comments

@ZoomRmc
Copy link

ZoomRmc commented Apr 26, 2020

Somewhere along the 0.18-0.17 cycles a regression was possibly introduced which increased CPU consumption on unhooked speed change, both for video or background audio and regardless of video resolution. Now my device glitches even on a pedestrian 1.10-1.15x speed. Previously I had no stutters up to 1.75x range at least. Current high CPU load persists on 0.19.2 and 0.19.3RC1 versions.

Unfortunately, I can't recall when the regression started, since I upgrade regularly. I can't check it either since older version crash with current YT (#1052 is essential, BTW, I don't really get why it's not implemented).

Sorry, don't know how to reproduce previous better behaviour.

Also, I'd like to stress that NewPipe gave me better performance and better sound quality than VLC's speed change (it will be embarrassing to hear if the use the same code for this), so I'd like to continue using it, preferably for downloaded content also.

Thanks for the hard work, NewPipe is awesome!

@ZoomRmc ZoomRmc added the bug Issue is related to a bug label Apr 26, 2020
@wb9688
Copy link
Contributor

wb9688 commented Apr 26, 2020

That's likely caused by the minor (not patch) ExoPlayer upgrade done in #2697

@Redirion
Copy link
Member

@wb9688 unfortunately I failed upgrading to the latest ExoPlayer 2.11. What are your suggestions? Could you maybe take a look at my attempt in PR #2859?

@Stypox
Copy link
Member

Stypox commented May 1, 2020

@ZoomRmc could you test the apk provided in #3513?

@ZoomRmc
Copy link
Author

ZoomRmc commented May 3, 2020

Sorry, no noticeable change for me. Crackling still starts at 1.2x.

I'm starting to entertain the possibility that's a problem on my end, but don't recall changing anything on my device that would introduce some constant activity degrading the overall performance. Anyway, it would be great to see some confirmation of the regression actually existing.

@opusforlife2
Copy link
Collaborator

Reply if it still happens in 0.19.8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue is related to a bug
Projects
None yet
Development

No branches or pull requests

5 participants