Links in description can't be copied

[AnXh3L0]

Version

• 0.18.7, latest from F-Droid

Steps to reproduce the bug

Steps to reproduce the behavior:

1. Go to any video which has long links in the description.
2. Links can be clicked on and will open correctly on the browser.
3. Try to copy the link(s) and paste somewhere else.

Expected behavior

The full link will be copied.

Actual behaviour

A clipped version of the link is copied.

Screenshots/Screen records

Can't provide screenshots right now.

Logs

Not a crash, just a bug, so no logs can be provided.

[wb9688]

That's because you're just copying the text, so that's not a bug. I think we should show some pop-up when you hold a link though where you could copy it (or open it or share it).

[TobiGr]

@wb9688 I was about to propose the same :D

[opusforlife2]

or open it

I'd like to point out an annoying behaviour regarding this. Newpipe treats even Youtube links as 3rd party app links. You get the option to choose the app if you have multiple versions of Newpipe installed. If you open that link, your backstack is gone, it's like a new instance of Newpipe has opened.

Ideally it should just open that link if it can and add it to the backstack.

[AnXh3L0]

@wb9688 in versions prior to 0.18.5 (afaik) there was no link clipping so one could copy it directly, but the pop-up option seems like a good solution for everyone.

[angriness-sleek]

I think we should show some pop-up when you hold a link though where you could copy it (or open it or share it).

the pop-up option seems like a good solution for everyone.

When there are multiple links in a video you want to copy, for example take this https://www.youtube.com/watch?v=3pYvJODjmjI, having to take a popup for every link isn't feasible

[illustribe]

Why can't it just work as usual android way of long tapping onto the link and having the standard little prompt of "open/copy/share" kind of thing?
It's extremely annoying not to be able to copy the links in the description, and not even being able to read them fully -in case I'd like to type em myself. And one more thing, it's not even working as it should when one clicks on a link, cause it doesn't open the usual "select the app to open with" prompt, at least in the case of a pdf link, it takes my straight to Google drive's app, even when I do have many pdf apps installed... :/

Also, I think ALL of the text from the description should be available for copying. Sometimes that is a need and here it's not possible :( having to recur to some other YT app...

Anyway, thanks and cheers! :)
🙏

[goyalyashpal]

i think this issue can be very well closed now, 'cz the story has long been diverged.

i would have mentioned the relevant link for where it did, but i dont remember the specifics.

[illustribe]

Yes, it's actually solved anyway since the select-all button was added 👍

[goyalyashpal]

select-all button

yeah, i meant that itself, but dont remember the corresponding version/commit/blog. if you do, then please mention it here :)

[opusforlife2]

Closing as solved, then.

[goyalyashpal]

hi @opusforlife2 do you remember in which version that select all button was introduced?

[opusforlife2]

PR: #5946.

Commit: bc3e43a

Edit: DIY tutorial. Long-pressing on the button in the app shows you the description text of the button. Then you search for that text in the strings.xml file in this repo. That gives you the key of that string used in the code. Searching for this key shows you all the places where it is used. Open any result (here, I chose what looked like the oldest modified code). Then select that line at the left, you'll see a 3 dot menu. Select that and click on git blame.

[AudricV]

Reopening as we are not able to copy full links on YouTube. I will open a PR which will add this ability soon.

[goyalyashpal]

Reopening as we are not able to copy full links on YouTube.

I have pasted my input regarding this over there #7725 (comment) .... umh, i just want to know which problem was fixed, as it seems all working to me