Release v0.16.2 #2314

TobiGr · 2019-04-30T18:08:41Z

We should release bug fixes from time to time... :)
Please test and share new crashes and bugs witch us below. Corresponding pull request: #2312

newpipe_0.16.2_rc2_debug.apk.zip (by @TobiGr)

Changelog

Improvements

add support for opening Invidio.us links
make links in comments clickable, increase text size make links in comments clickable, increase text size #2168
seek on clicking timestamp links in comments seek on clicking timestamp links in comments #2207
show preferred tab based on recently selected state preferred tab based on selected state, fixes #2238 #2247
add playlist to queue when long clicking on 'Background' in playlist window Add playlist to queue when long clicking on 'Background' #2023
search for shared text when it is not an URL Issue #1951 - Search shared text #1963
add "share at current time" button to the main video player Add "share at current time" button to the main video player #2271
add close button to main player when video queue is finished Show close button when playing completed #1969
add "Play directly in Background" to longpress menu for video list items Directplay on Background #2198
improve English translations for Play/Enqueue commands Fixed English translations for Play/Enqueue commands #2237
small performance improvements Cache duration String to improve performance #2178, Improve performance of getTimeString #2179
remove unused files delete unused files #2183
update ExoPlayer to 2.9.6 Update ExoPlayer to 2.9.6 #2184, Readd CustomTrackSelector #2311

Fixed

fixed scroll w/ comments and related streams disabled fixed scroll w/ comments and related streams disabled #2176
fixed CheckForNewAppVersionTask being executed when it shouldn't Fixed CheckForNewAppVersionTask being executed when it shouldn't #2161
fixed youtube subscription import: ignore ones with invalid url and keep ones with empty title Fixed youtube subscription import: ignore ones with invalid url and keep ones with empty title. NewPipeExtractor#160
fix invalid YouTube url: signature tag name is not always "signature" preventing streams from loading Fix invalid yt url: signature tag name is not always "signature" NewPipeExtractor#163

ToDo

Update Weblate translations

VGkav · 2019-05-05T00:00:56Z

On the last stable, in the What's New page only shows some videos and then just sits there with the loading icon. Is that a known bug?

H2172 · 2019-05-05T14:20:10Z

version in RC1 is reported incorrectly as 0.16.0

H2172 · 2019-05-05T14:24:10Z

not entirely sure which steps led to this, hence unable to replicate, but sharing just in case:

Exception

User Action: ui error
Request: App crash, UI failure
Service: none
Version: 0.16.0
OS: Linux Android 5.0.2 - 21

Crash log

java.lang.RuntimeException: Unable to start activity ComponentInfo{org.schabi.newpipe.debug/org.schabi.newpipe.about.AboutActivity}: java.lang.ClassCastException: android.os.Parcelable[] cannot be cast to org.schabi.newpipe.about.SoftwareComponent[]
	at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:2298)
	at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:2358)
	at android.app.ActivityThread.access$800(ActivityThread.java:144)
	at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1278)
	at android.os.Handler.dispatchMessage(Handler.java:102)
	at android.os.Looper.loop(Looper.java:135)
	at android.app.ActivityThread.main(ActivityThread.java:5219)
	at java.lang.reflect.Method.invoke(Native Method)
	at java.lang.reflect.Method.invoke(Method.java:372)
	at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:898)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:693)
	at de.robv.android.xposed.XposedBridge.main(XposedBridge.java:107)
Caused by: java.lang.ClassCastException: android.os.Parcelable[] cannot be cast to org.schabi.newpipe.about.SoftwareComponent[]
	at org.schabi.newpipe.about.LicenseFragment.onCreate(LicenseFragment.java:49)
	at android.support.v4.app.Fragment.performCreate(Fragment.java:2414)
	at android.support.v4.app.FragmentManagerImpl.moveToState(FragmentManager.java:1418)
	at android.support.v4.app.FragmentManagerImpl.moveFragmentToExpectedState(FragmentManager.java:1784)
	at android.support.v4.app.FragmentManagerImpl.moveToState(FragmentManager.java:1852)
	at android.support.v4.app.FragmentManagerImpl.dispatchStateChange(FragmentManager.java:3269)
	at android.support.v4.app.FragmentManagerImpl.dispatchCreate(FragmentManager.java:3223)
	at android.support.v4.app.FragmentController.dispatchCreate(FragmentController.java:190)
	at android.support.v4.app.FragmentActivity.onCreate(FragmentActivity.java:369)
	at android.support.v7.app.AppCompatActivity.onCreate(AppCompatActivity.java:85)
	at org.schabi.newpipe.about.AboutActivity.onCreate(AboutActivity.java:64)
	at android.app.Activity.performCreate(Activity.java:5976)
	at android.app.Instrumentation.callActivityOnCreate(Instrumentation.java:1105)
	at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:2251)
	... 11 more
java.lang.ClassCastException: android.os.Parcelable[] cannot be cast to org.schabi.newpipe.about.SoftwareComponent[]
	at org.schabi.newpipe.about.LicenseFragment.onCreate(LicenseFragment.java:49)
	at android.support.v4.app.Fragment.performCreate(Fragment.java:2414)
	at android.support.v4.app.FragmentManagerImpl.moveToState(FragmentManager.java:1418)
	at android.support.v4.app.FragmentManagerImpl.moveFragmentToExpectedState(FragmentManager.java:1784)
	at android.support.v4.app.FragmentManagerImpl.moveToState(FragmentManager.java:1852)
	at android.support.v4.app.FragmentManagerImpl.dispatchStateChange(FragmentManager.java:3269)
	at android.support.v4.app.FragmentManagerImpl.dispatchCreate(FragmentManager.java:3223)
	at android.support.v4.app.FragmentController.dispatchCreate(FragmentController.java:190)
	at android.support.v4.app.FragmentActivity.onCreate(FragmentActivity.java:369)
	at android.support.v7.app.AppCompatActivity.onCreate(AppCompatActivity.java:85)
	at org.schabi.newpipe.about.AboutActivity.onCreate(AboutActivity.java:64)
	at android.app.Activity.performCreate(Activity.java:5976)
	at android.app.Instrumentation.callActivityOnCreate(Instrumentation.java:1105)
	at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:2251)
	at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:2358)
	at android.app.ActivityThread.access$800(ActivityThread.java:144)
	at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1278)
	at android.os.Handler.dispatchMessage(Handler.java:102)
	at android.os.Looper.loop(Looper.java:135)
	at android.app.ActivityThread.main(ActivityThread.java:5219)
	at java.lang.reflect.Method.invoke(Native Method)
	at java.lang.reflect.Method.invoke(Method.java:372)
	at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:898)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:693)
	at de.robv.android.xposed.XposedBridge.main(XposedBridge.java:107)

Brimont · 2019-05-07T13:06:51Z

Exception

User Action: subscription
Request: https://www.youtube.com/channel/UCaGQh5lmPvro4fjw3-Nyf1g
Content Language: IT
Service: YouTube
Version: 0.16.0
OS: Linux Android 4.4 - 19

Crash log

org.schabi.newpipe.extractor.exceptions.ParsingException: Could not get channel name
	at org.schabi.newpipe.extractor.services.youtube.extractors.YoutubeChannelExtractor.getName(YoutubeChannelExtractor.java:100)
	at org.schabi.newpipe.extractor.channel.ChannelInfo.getInfo(ChannelInfo.java:62)
	at org.schabi.newpipe.extractor.channel.ChannelInfo.getInfo(ChannelInfo.java:49)
	at org.schabi.newpipe.util.ExtractorHelper.lambda$getChannelInfo$4(ExtractorHelper.java:123)
	at org.schabi.newpipe.util.-$$Lambda$ExtractorHelper$u5W7VszTe8AoEexIsFM9huQfbkM.call(lambda)
	at io.reactivex.internal.operators.single.SingleFromCallable.subscribeActual(SingleFromCallable.java:44)
	at io.reactivex.Single.subscribe(Single.java:3438)
	at io.reactivex.internal.operators.single.SingleDoOnSuccess.subscribeActual(SingleDoOnSuccess.java:35)
	at io.reactivex.Single.subscribe(Single.java:3438)
	at io.reactivex.internal.operators.maybe.MaybeFromSingle.subscribeActual(MaybeFromSingle.java:41)
	at io.reactivex.Maybe.subscribe(Maybe.java:4154)
	at io.reactivex.internal.operators.maybe.MaybeConcatArray$ConcatMaybeObserver.drain(MaybeConcatArray.java:153)
	at io.reactivex.internal.operators.maybe.MaybeConcatArray$ConcatMaybeObserver.request(MaybeConcatArray.java:78)
	at io.reactivex.internal.operators.flowable.FlowableElementAtMaybe$ElementAtSubscriber.onSubscribe(FlowableElementAtMaybe.java:66)
	at io.reactivex.internal.operators.maybe.MaybeConcatArray.subscribeActual(MaybeConcatArray.java:42)
	at io.reactivex.Flowable.subscribe(Flowable.java:14479)
	at io.reactivex.internal.operators.flowable.FlowableElementAtMaybe.subscribeActual(FlowableElementAtMaybe.java:36)
	at io.reactivex.Maybe.subscribe(Maybe.java:4154)
	at io.reactivex.internal.operators.maybe.MaybeToSingle.subscribeActual(MaybeToSingle.java:46)
	at io.reactivex.Single.subscribe(Single.java:3438)
	at io.reactivex.internal.operators.maybe.MaybeFromSingle.subscribeActual(MaybeFromSingle.java:41)
	at io.reactivex.Maybe.subscribe(Maybe.java:4154)
	at io.reactivex.internal.operators.maybe.MaybeSubscribeOn$SubscribeTask.run(MaybeSubscribeOn.java:54)
	at io.reactivex.internal.schedulers.ScheduledDirectTask.call(ScheduledDirectTask.java:38)
	at io.reactivex.internal.schedulers.ScheduledDirectTask.call(ScheduledDirectTask.java:26)
	at java.util.concurrent.FutureTask.run(FutureTask.java:234)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1080)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:573)
	at java.lang.Thread.run(Thread.java:838)
Caused by: java.lang.NullPointerException
	at org.schabi.newpipe.extractor.services.youtube.extractors.YoutubeChannelExtractor.getName(YoutubeChannelExtractor.java:98)
	... 28 more

avently · 2019-05-07T21:52:41Z

@TobiGr @theScrabi
From time-to-time I'm visiting NewPipe's repo and can't find a player inside fragment feature implemented. Is it really non-important for everyone?
I'm comparing current version and 2017 year's version I use everyday. And it looks a bit different but no major changes in features list (except comments support and some other cool things).

For me it's pretty strange to not have the player that works inside a window with comments, description, etc.

gkeegan · 2019-05-07T23:37:50Z

@avently
#834 If you allow people access to use this it may speed up the process of getting a fragment player. I believe it wasn't merged in the time frame you wanted because there were bug fixes that needed to be fixed first.

Also, many things have been added. They just aren't front end things. Better downloaders, more stable players, and other things have all been added. These things aren't really visible to the end user, but make for a more stable experience, which imo is better than willy nilly adding new features.

avently · 2019-05-08T00:26:46Z

@gkeegan

#838 If you allow people access to use this it may speed up the process

Everyone can use my code from that PR without restrictions. I only said the PR shouldn't be reopened since no decisions were made for a long time. If a strategy doesn't work, make a new strategy:)

Anyway, I have been using the code for years but not without problems. They are not critical and can be fixed easily.

The idea behind the code is good but result could be better. And one large PR is a bad idea - multiple small pull requests is better in this case.

gkeegan · 2019-05-08T01:32:29Z

@avently

From that PR,

And for the record, you are not allowed to reopen this PR. Create your own. This will be the history of my fail.

Sorry for the misunderstanding. I thought that "create your own" meant that people couldn't use it.

shmil111 · 2019-05-10T04:02:54Z

I'm experiencing a problem in playing specific videos on the background player.
It just doesn't load.
The problem is span across many versions of the app.

An example of a video like this:
https://www.youtube.com/watch?v=EWSNOSv9TAs

It happens quite often.

I tried forcing shutdown of the app and trying to load it again, I tried even uninstalling the app and downloading it again, and the same song still won't load (but only on background mode).

I know with a problem so unspecific like this I'm not helping you much.
I assume the problem is specific to me since it happens so often if it was happening for everyone it for sure would've been reported and fixed already.

VGkav · 2019-05-10T11:30:06Z

I have it running in background now.

H2172 · 2019-05-10T14:45:19Z

downloading videos stuck at "post processing"

TobiGr · 2019-05-12T15:22:14Z

Thanks you all for testing!

@Anotherlife This is an old bug and will be fixed in #2309 (not in this release)

@ZMRH I couldn't reproduce this either. Maybe on of these annoying Android 5 bugs? :)

@Brimont This is an extractor exception. But we didn't touch any related code. So I guess this was either a temporary bug or it exists in other versions, too.

@avently It's good to hear from you! Welcome back. An embedded player is definetely on our list.

Everyone can use my code from that PR without restrictions.

That's good to hear. I also thought we weren't allowed to reuse the code. I guess parts of it are very useful for us.

The idea behind the code is good but result could be better. And one large PR is a bad idea - multiple small pull requests is better in this case.

Yes, splitting this up into small PRs makes much sense and reviewing, testing and QA faster.

@shmil111 Yes, me too. But this is not related to this PR as I have problems with it on both versions. We should track this down in #2336 and #2337.

@ZMRH will be fixed in #2149 (next release)

avently · 2019-05-12T16:28:58Z

@TobiGr could you make a new issue with todo list related to an embedded player implementation?
I want to adapt the embedded player to new codebase. Maybe other devs will be glad to help too

TobiGr · 2019-05-14T21:52:31Z

Thanks to @Stypox, we can ship two more fixes with 0,16.2:

prevent streams from not loading
fix YouTube subscription import

Here is the new RC: newpipe_0.16.2_rc2_debug.apk.zip

TobiGr · 2019-05-14T22:02:55Z

@avently Sure, but this might take a while as I would like to release the new version first and then review the three large PRs. I hope, I have some time in between, because I'd like to take a look at the old code, too. @theScrabi, @mauriciocolli In case you have some spare time, feel free to contribute to the list.

pihug12 · 2019-05-16T07:36:52Z

I didn't test it with v0.16.2 too, but I witness issues with some SoundCloud streams (not all of them) since yesterday (#2344 & TeamNewPipe/NewPipeExtractor#166). It may be release-blocking?

Exception

User Action: requested stream
Request: https://soundcloud.com/metalheadz/scar-sleep-talk
Content Language: FR
Service: SoundCloud
Version: 0.16.1
OS: Linux samsung/heroltexx/herolte:8.0.0/R16NW/G930FXXU4ESB4:user/release-keys 8.0.0 - 26

Crash log

org.schabi.newpipe.extractor.exceptions.ParsingException: Attempt to invoke virtual method 'java.lang.String org.jsoup.nodes.Node.attr(java.lang.String)' on a null object reference
	at org.schabi.newpipe.extractor.services.soundcloud.SoundcloudStreamLinkHandlerFactory.getUrl(SoundcloudStreamLinkHandlerFactory.java:25)
	at org.schabi.newpipe.extractor.linkhandler.LinkHandlerFactory.fromUrl(LinkHandlerFactory.java:47)
	at org.schabi.newpipe.extractor.StreamingService.getStreamExtractor(StreamingService.java:288)
	at org.schabi.newpipe.extractor.stream.StreamInfo.getInfo(StreamInfo.java:59)
	at org.schabi.newpipe.util.ExtractorHelper.lambda$getStreamInfo$3(ExtractorHelper.java:115)
	at org.schabi.newpipe.util.-$$Lambda$ExtractorHelper$5fJcha6Sq5APJBLdG6osaJby-mc.call(Unknown Source:4)
	at io.reactivex.internal.operators.single.SingleFromCallable.subscribeActual(SingleFromCallable.java:44)
	at io.reactivex.Single.subscribe(Single.java:3438)
	at io.reactivex.internal.operators.single.SingleDoOnSuccess.subscribeActual(SingleDoOnSuccess.java:35)
	at io.reactivex.Single.subscribe(Single.java:3438)
	at io.reactivex.internal.operators.maybe.MaybeFromSingle.subscribeActual(MaybeFromSingle.java:41)
	at io.reactivex.Maybe.subscribe(Maybe.java:4154)
	at io.reactivex.internal.operators.maybe.MaybeConcatArray$ConcatMaybeObserver.drain(MaybeConcatArray.java:153)
	at io.reactivex.internal.operators.maybe.MaybeConcatArray$ConcatMaybeObserver.request(MaybeConcatArray.java:78)
	at io.reactivex.internal.operators.flowable.FlowableElementAtMaybe$ElementAtSubscriber.onSubscribe(FlowableElementAtMaybe.java:66)
	at io.reactivex.internal.operators.maybe.MaybeConcatArray.subscribeActual(MaybeConcatArray.java:42)
	at io.reactivex.Flowable.subscribe(Flowable.java:14479)
	at io.reactivex.internal.operators.flowable.FlowableElementAtMaybe.subscribeActual(FlowableElementAtMaybe.java:36)
	at io.reactivex.Maybe.subscribe(Maybe.java:4154)
	at io.reactivex.internal.operators.maybe.MaybeToSingle.subscribeActual(MaybeToSingle.java:46)
	at io.reactivex.Single.subscribe(Single.java:3438)
	at io.reactivex.internal.operators.single.SingleSubscribeOn$SubscribeOnObserver.run(SingleSubscribeOn.java:89)
	at io.reactivex.Scheduler$DisposeTask.run(Scheduler.java:578)
	at io.reactivex.internal.schedulers.ScheduledRunnable.run(ScheduledRunnable.java:66)
	at io.reactivex.internal.schedulers.ScheduledRunnable.call(ScheduledRunnable.java:57)
	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
	at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:301)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1162)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:636)
	at java.lang.Thread.run(Thread.java:764)
Caused by: java.lang.NullPointerException: Attempt to invoke virtual method 'java.lang.String org.jsoup.nodes.Node.attr(java.lang.String)' on a null object reference
	at org.schabi.newpipe.extractor.services.soundcloud.SoundcloudParsingHelper.resolveUrlWithEmbedPlayer(SoundcloudParsingHelper.java:104)
	at org.schabi.newpipe.extractor.services.soundcloud.SoundcloudStreamLinkHandlerFactory.getUrl(SoundcloudStreamLinkHandlerFactory.java:23)
	... 29 more

ouzowtf · 2019-05-16T12:11:37Z

The SoundCloud issues are there with 0.16.2 RC2 too.

TobiGr · 2019-05-17T08:12:04Z

We didn't change anything related to SoundCloud in this release. It looks like the SoundCloud API changed. a bunch of SoundCloud tests are failing (see extractor). As long as nobody takes a look at it, this will be unfixed in 0.16.2. But be assured, that we will dive into it soon.

Paris302 · 2019-05-27T15:05:00Z

Add a recommendation tab

Stypox · 2019-05-27T15:25:58Z

@Paris302 You could open an issue for that

TobiGr mentioned this issue Apr 30, 2019

Release v0.16.2 #2312

Merged

1 task

Redirion mentioned this issue May 16, 2019

App does not detect when the device is offline #2326

Closed

TobiGr mentioned this issue May 17, 2019

Can't parse website (Soundcloud playlist) #2344

Closed

This was referenced May 21, 2019

Cannot import subscriptions from YouTube #2194

Closed

player is slow and don't work sometimes. #2356

Closed

Stypox mentioned this issue May 31, 2019

Network error on import youtube subscription #2374

Closed

3 tasks

TobiGr closed this as completed May 31, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Release v0.16.2 #2314

Release v0.16.2 #2314

TobiGr commented Apr 30, 2019 •

edited

Loading

VGkav commented May 5, 2019

H2172 commented May 5, 2019

H2172 commented May 5, 2019 •

edited

Loading

Brimont commented May 7, 2019 •

edited

Loading

avently commented May 7, 2019

gkeegan commented May 7, 2019

avently commented May 8, 2019

gkeegan commented May 8, 2019

shmil111 commented May 10, 2019

VGkav commented May 10, 2019

H2172 commented May 10, 2019

TobiGr commented May 12, 2019

avently commented May 12, 2019

TobiGr commented May 14, 2019

TobiGr commented May 14, 2019

pihug12 commented May 16, 2019 •

edited

Loading

ouzowtf commented May 16, 2019

TobiGr commented May 17, 2019 •

edited

Loading

Paris302 commented May 27, 2019

Stypox commented May 27, 2019

Release v0.16.2 #2314

Release v0.16.2 #2314

Comments

TobiGr commented Apr 30, 2019 • edited Loading

Changelog

Improvements

Fixed

ToDo

VGkav commented May 5, 2019

H2172 commented May 5, 2019

H2172 commented May 5, 2019 • edited Loading

Exception

Brimont commented May 7, 2019 • edited Loading

Exception

avently commented May 7, 2019

gkeegan commented May 7, 2019

avently commented May 8, 2019

gkeegan commented May 8, 2019

shmil111 commented May 10, 2019

VGkav commented May 10, 2019

H2172 commented May 10, 2019

TobiGr commented May 12, 2019

avently commented May 12, 2019

TobiGr commented May 14, 2019

TobiGr commented May 14, 2019

pihug12 commented May 16, 2019 • edited Loading

Exception

ouzowtf commented May 16, 2019

TobiGr commented May 17, 2019 • edited Loading

Paris302 commented May 27, 2019

Stypox commented May 27, 2019

TobiGr commented Apr 30, 2019 •

edited

Loading

H2172 commented May 5, 2019 •

edited

Loading

Brimont commented May 7, 2019 •

edited

Loading

pihug12 commented May 16, 2019 •

edited

Loading

TobiGr commented May 17, 2019 •

edited

Loading