Re-add ability to autoplay video when directly opened

[Phoenix616]

• I carefully read the contribution guidelines and agree to them.
• I checked if the issue/feature exists in the latest version.
• I did use the incredible bugreport to markdown converter to paste bug reports.

There used to be a setting with which videos would automatically start playing if you opened the info page from another app. This functionality seems to have been removed in a recent update and I would like to request it to be added back in. (It was optional to begin with so wouldn't hurt anyone)

I realise that a similar behaviour is possible by selecting "Video Player" as the "Preferred 'open' option" but that has one major drawback: You are not able to quickly go to view the video info activity by pressing the back button e.g. to go to the channel page or view related videos.

There doesn't even seem to be any way to get to the video info from the player as far as I can tell so an extra info button might be useful there too. (But I would prefer the old way because although a new button might work it would still break my "workflow" ;P)

[Phoenix616]

Yeah that issue kinda relates to my last thought of there not being a way to view the info from the player.

But please note that I'm not requesting that the back button leads to the info page when selecting "Video Player" on the "Open"-dialog, I'm requesting for the old, removed feature being re-added that let us auto-play the video when it was opened from another app and "Show Info" was selected in the "Open" dialog. (Could even be a new "Show Info & Autoplay" option that is later used in an eventual in-info player as requested in #1831)

[Phoenix616]

I just noticed that this functionality still works on another device of mine and noticed that the stored preference autoplay_through_intent was set which seems to still work even though it doesn't have a config option anymore. Can't really check why — git blame is a bit hard to use on mobile — but will hopefully track the commit that removed it from the menu down soon.

[Phoenix616]

Actually I managed to find the commit that removed the settings entry: cbfe91f

Was there a reasoning behind removang that @theScrabi and would there be an issue with just re-adding the setting? Because the commit message doesn't seem to really include that... (personally I'm not a fan of multi feature change commits with very short changenotes for this reason)

[nyanpasu64]

This behavior was not removed, but the preference entry to turn it on/off was removed from the GUI, while keeping the choice made in an earlier version of the app!

As a result, this invisible config entry causes some older app installations to either autoplay video or not, without any visible configuration differences.

Both 0.16.2 and dev 6a0450b exhibit this hidden state behavior.

[Stypox]

I think it would be better to completely drop the autoplay feature and instead implement #1873 (pull request open: #2430)

[Phoenix616]

The linked issue and PR would be basically useless without the autoplay?

[Stypox]

Why? The back button on the screen would bring the user to the video info, while the hardware back button would close the activity.

[Phoenix616]

Without auto play being a thing both of these would be exactly the same as the info view will always be the previous activity.

What's your reasoning behind suggesting to remove autoplay anyways? You just linked a slightly related issue/PR without actually going into that.

[Stypox]

No, the info view will never be the previous activity. The only change in the pull request is a button that opens a new info activity on top of the video. This way you can access both the previous screen (with the phone's back button) and the info page (with the app's specific button).

[Phoenix616]

Oh, I forgot about "Video Player" being one of the preferred options then yeah, if an info view button would be added that would be enough to provide an alternative way to get to the info page I guess. (Would still break my workflow but ¯\_(ツ)_/¯ )

[Stypox]

The way you used "autoplay" was more of a workaround than a solution, this is why I think the solution in #2430 is better... sorry for this ;-)

[Stypox]

Fixed in #2907, since the autoplay toggle now exists. Refer to #4071 for autoplay not working upon share