Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] mark watched videos as "watched" #1750

Closed
2 tasks done
MaX-Lo opened this issue Sep 22, 2018 · 14 comments
Closed
2 tasks done

[Feature Request] mark watched videos as "watched" #1750

MaX-Lo opened this issue Sep 22, 2018 · 14 comments

Comments

@MaX-Lo
Copy link
Contributor

MaX-Lo commented Sep 22, 2018

  • I carefully read the contribution guidelines and agree to them.
  • I checked if the issue/feature exists in the latest version.

One thing I noticed, is that after discovering a cool channel I often see me watching many of its videos. On NewPipe watched videos appear in the history but aren't highlighted as "watched" when scrolling through a channel or search results. For me that results in accidentally rewatching videos from time to time. You get it after like 10sec, but it's kind of annoying.

So, since NewPipe stores a history of watched videos anyway it could maybe get used for marking watched videos as such. (similar to the official Youtube site)

@MaX-Lo MaX-Lo changed the title mark watched video as "watched" mark watched videos as "watched" Sep 22, 2018
@MaX-Lo MaX-Lo changed the title mark watched videos as "watched" [Feature Request] mark watched videos as "watched" Sep 22, 2018
@ghost
Copy link

ghost commented Sep 23, 2018

What if there were a cursor showing how far you scrolled within a feed like Telegram?

@MaX-Lo
Copy link
Contributor Author

MaX-Lo commented Sep 23, 2018

I'm not sure if I understand you correctly, so I added a little mockup. I think a little overlay on the thumbnail isn't that intruding and would already do the trick.

np_watched_mockup

@Jluedtke19
Copy link

I'm working on this sort of implantation right now.

@MaX-Lo
Copy link
Contributor Author

MaX-Lo commented Sep 26, 2018

Nice to hear that. I did it on my fork too, but I'm not satisfied with my solution yet. Really interested in how your solution will look like.

@Jluedtke19
Copy link

How far did you get, I'm having trouble trying to get the streamhistorytable in the History Record Manager from the StreamMiniInfoItemHolder

@justanidea
Copy link
Contributor

Guys have a look of #1448

@MaX-Lo
Copy link
Contributor Author

MaX-Lo commented Sep 26, 2018

Exactly my Point. I added the watched Label in the VideoDetailFragment.
I got so far that before you start a video the watched label gets displayed, in case you watched it already, and on related videos it gets shown as well.

@MaX-Lo
Copy link
Contributor Author

MaX-Lo commented Sep 26, 2018

@justanidea isn't that something different? #1448 is about marking new videos whereas this is about marking already watched videos to prevent double watching?

@justanidea
Copy link
Contributor

Mb

@woj-tek
Copy link
Contributor

woj-tek commented Oct 1, 2018

Instead of creating new issue I would like to suggest small addition to this one: "Mark video as watched" in Subscriptions page/view - I would like to subscribe to a number of channels but I rarely watch all videos. I could simply swipe-off items I don't want to watch.

@stale
Copy link

stale bot commented Dec 1, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Dec 1, 2018
@MaX-Lo
Copy link
Contributor Author

MaX-Lo commented Dec 3, 2018

Still think it would be a nice feature. Just hat no time to implement it yet...

@stale stale bot removed the stale label Dec 3, 2018
@infinitytec
Copy link

I'd like it as well.

@Stypox
Copy link
Member

Stypox commented Aug 28, 2019

Closing in favour of #2567 since it has more information

@Stypox Stypox closed this as completed Aug 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants