Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SoundCloud Download "Unknown Quality" audio cannot be played #10153

Closed
6 tasks done
esn89 opened this issue Jun 10, 2023 · 10 comments · Fixed by #10165
Closed
6 tasks done

SoundCloud Download "Unknown Quality" audio cannot be played #10153

esn89 opened this issue Jun 10, 2023 · 10 comments · Fixed by #10165
Assignees
Labels
bug Issue is related to a bug downloader Issue is related to the downloader soundcloud Service, https://soundcloud.com/

Comments

@esn89
Copy link

esn89 commented Jun 10, 2023

Checklist

  • I am able to reproduce the bug with the latest version.
  • I made sure that there are no existing issues - open or closed - which I could contribute my information to.
  • I have read the FAQ and my problem isn't listed.
  • I have taken the time to fill in all the required details. I understand that the bug report will be dismissed otherwise.
  • This issue contains only one bug.
  • I have read and understood the contribution guidelines.

Affected version

0.25.1

Steps to reproduce the bug

  1. Go to NewPipe
  2. Go to the SoundCloud option
  3. Find a song that allows you to download in bitrate higher than 125kbps. Normally it says "Unknown Quality" with a filesize significantly bigger than the default mp3 128kbps.
  4. Download it
  5. Try to play it with AIMP
  6. Go to terminal of your phone and do file $DOWNLOADED_FILE it says file type is just "data".

Expected behavior

I should be able to play this file.

Actual behavior

Music players cannot play the downloaded file.
Linux does not detect the extension.

Screenshots/Screen recordings

screenshot

Logs

No crash logs.

Affected Android/Custom ROM version

Android 13, OxygenOS

Affected device model

OnePlus 8 Pro

Additional information

No response

@esn89 esn89 added bug Issue is related to a bug needs triage Issue is not yet ready for PR authors to take up labels Jun 10, 2023
@opusforlife2
Copy link
Collaborator

Why have you put a link to this issue in the Screenshots section?

@opusforlife2 opusforlife2 added the waiting for author If the author doesn't respond, the issue will be auto-closed. Otherwise the label will be removed. label Jun 10, 2023
@esn89
Copy link
Author

esn89 commented Jun 11, 2023

Ooops, here is the image:

https://imgur.com/a/FzmS61B

@github-actions github-actions bot removed the waiting for author If the author doesn't respond, the issue will be auto-closed. Otherwise the label will be removed. label Jun 11, 2023
@opusforlife2
Copy link
Collaborator

You brave beast. I would have never touched a 1/2 GB file pretending to be an audio.

@opusforlife2 opusforlife2 added soundcloud Service, https://soundcloud.com/ downloader Issue is related to the downloader and removed needs triage Issue is not yet ready for PR authors to take up labels Jun 11, 2023
@esn89
Copy link
Author

esn89 commented Jun 11, 2023

@opusforlife2 since this is a whole DJ set about ~1 hour, it is quite possible if it is a flac :)

@opusforlife2
Copy link
Collaborator

We don't parse any stream other than MP3 and Opus on Soundcloud, from what I remember.

@TobiGr
Copy link
Member

TobiGr commented Jun 15, 2023

@esn89 Please test the APK in #10165 . I was able to test the it with the song you provided in the screen shot. That download is an AIFF file. SoundCloud artists can upload streams with other formats, too. I was not able to find one which uses another format. If you do, please tell us if it works.

@esn89
Copy link
Author

esn89 commented Jun 19, 2023

@TobiGr , let me test this out. Give me some time :)

@esn89
Copy link
Author

esn89 commented Jun 20, 2023

It downloads, but, it saves as a 49.4mb mp3 instead.

@TobiGr
Copy link
Member

TobiGr commented Jul 14, 2023

@esn89 That's a regression which was recently introduced. I'll have to fix it first (see #10180)

@TobiGr
Copy link
Member

TobiGr commented Jul 14, 2023

Please test the latest APK once the build is finished, everything should work now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue is related to a bug downloader Issue is related to the downloader soundcloud Service, https://soundcloud.com/
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants