-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a splash screen when Amaze loads #3442
Add a splash screen when Amaze loads #3442
Conversation
Signed-off-by: dhruv <[email protected]>
Signed-off-by: dhruv <[email protected]>
hello @EmmanuelMess can you please review this PR . |
@EmmanuelMess may you please help me how i can i resolve these checks , as am not getting a proper solution for it . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The image used should not be a png, it should be an svg.
@@ -120,6 +120,7 @@ dependencies { | |||
implementation "com.google.android.material:material:$androidMaterialVersion" | |||
implementation "androidx.fragment:fragment-ktx:$androidXFragmentVersion" | |||
implementation "androidx.appcompat:appcompat:$androidXAppCompatVersion" | |||
implementation 'androidx.core:core-splashscreen:1.0.0-beta01' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You might not want to use the splash screen library if it has API level issues.
You should run spotlessApply to fix check spotless. |
A failing test:
Are you using getDrawable on the wrong API level? |
@EmmanuelMess ok I will remove the library. |
I think you can use an activity to show an image, and start the main activity from there, so that the main activity loads with the initial image as background. |
@EmmanuelMess , i am not able to create a new activity as the minsdk is 14 but requires 16(minimum) for that i have to change the minsdk 14 to 16 |
That's with the dialog, you should create it by hand, or convert what the dialog creates to an API 14 compatible version. |
@EmmanuelMess is there any svg available for the icon in the project as i am not able to find it ? |
Signed-off-by: dhruv [email protected]
closes #3139
Description
Issue tracker
Fixes #3139
Automatic tests
Manual tests
Build tasks success
Successfully running following tasks on local:
./gradlew assembledebug
./gradlew spotlessCheck