Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] 2차 스프린트 기능 QA 반영 #289

Open
2 tasks done
EunsuSeo01 opened this issue Nov 10, 2024 · 0 comments · May be fixed by #294
Open
2 tasks done

[Fix] 2차 스프린트 기능 QA 반영 #289

EunsuSeo01 opened this issue Nov 10, 2024 · 0 comments · May be fixed by #294
Assignees
Labels
🐬 은수 은수 공주 작업 🛠️ Fix 버그, 오류 해결

Comments

@EunsuSeo01
Copy link
Member

EunsuSeo01 commented Nov 10, 2024

🛠 Issue

  • 1108 2차 스프린트 기능 QA를 반영합니다.
  • 미완성이었던 메뉴 추가를 완벽히 구현합니다.

📝 To-do

  • 메뉴 추가 쪽 완성
  • 기능 QA 모두 반영 완료 - 이따 적겠음
@EunsuSeo01 EunsuSeo01 added 🛠️ Fix 버그, 오류 해결 🐬 은수 은수 공주 작업 labels Nov 10, 2024
@EunsuSeo01 EunsuSeo01 self-assigned this Nov 10, 2024
EunsuSeo01 added a commit that referenced this issue Nov 13, 2024
제보하기의 메뉴 셀에도 동일하게 적용 완료함
EunsuSeo01 added a commit that referenced this issue Nov 14, 2024
MenuData에서 MenuRequestDTO로 구조를 변경하는 toMenuRequestDTO 함수도 추가함
EunsuSeo01 added a commit that referenced this issue Nov 14, 2024
EunsuSeo01 added a commit that referenced this issue Nov 14, 2024
removeConstraints 후 다시 makeConstraints 함으로써 높이 안 늘어나던 이슈 해결
EunsuSeo01 added a commit that referenced this issue Nov 14, 2024
다른 메뉴도 추가하기 클릭했을 때를 대비
EunsuSeo01 added a commit that referenced this issue Nov 14, 2024
doThisAgainButton 클릭 후 네비바의 뒤로가기 버튼 클릭 시에 식당 상세 화면이 나오는데
이때에도 업데이트 된 최신 메뉴 리스트를 보여주기 위해서
EunsuSeo01 added a commit that referenced this issue Nov 14, 2024
API 구현 전이라 임의로 식당 상세 보기의 API에서 메뉴 리스트만 가져와서 썼던 걸 새 API로 변경
EunsuSeo01 added a commit that referenced this issue Nov 15, 2024
서버가 dto 구조 하나로 통일해줘서 반영함
EunsuSeo01 added a commit that referenced this issue Nov 15, 2024
편집에서 바로 삭제 시 로직 변경
수정 중에 가격 넘어서 삭제할 때에도 적용함
EunsuSeo01 added a commit that referenced this issue Nov 15, 2024
EunsuSeo01 added a commit that referenced this issue Nov 15, 2024
문구를 포함하여 버튼 로직 변경
EunsuSeo01 added a commit that referenced this issue Nov 15, 2024
EunsuSeo01 added a commit that referenced this issue Nov 15, 2024
EunsuSeo01 added a commit that referenced this issue Nov 15, 2024
원래는 연필 버튼 클릭 시에만 수정 가능하게 막아뒀었는데 이를 없앰
EunsuSeo01 added a commit that referenced this issue Nov 15, 2024
연필 버튼 클릭 시와 동일한 로직으로 동작하도록 탭 제스처 추가함
EunsuSeo01 added a commit that referenced this issue Nov 15, 2024
원래 값과 메뉴 이름 또는 가격이 다를 때에만 활성화 되도록
EunsuSeo01 added a commit that referenced this issue Nov 16, 2024
EunsuSeo01 added a commit that referenced this issue Nov 16, 2024
EunsuSeo01 added a commit that referenced this issue Nov 16, 2024
하나의 프로토콜에 있던 함수 2개를 각각의 프로토콜로 분리했다
AddVC에서는 원래 프로토콜의 함수 중 1개의 함수만 사용했기 때문이다
EunsuSeo01 added a commit that referenced this issue Nov 17, 2024
로직을 간소화 하고 알아보기 쉽게 동작마다 함수로 분
@EunsuSeo01 EunsuSeo01 linked a pull request Nov 17, 2024 that will close this issue
3 tasks
@EunsuSeo01 EunsuSeo01 linked a pull request Nov 17, 2024 that will close this issue
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐬 은수 은수 공주 작업 🛠️ Fix 버그, 오류 해결
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant