-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor [#91] LoginFeature 리펙토링 #108
Open
kim-seonwoo
wants to merge
15
commits into
develop
Choose a base branch
from
refactor/#91-login
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+217
−206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zoe0929
approved these changes
Nov 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
뷰모델이 완전 깔!끔!해졌네요! 고생하셨습니다~
HELLOHIDI
approved these changes
Nov 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
너무 고생했습니다. 각 객체의 명확한 책임이 나타나네요!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👾 작업 내용
LoginUseCase
UseCase는 login이라는 하나의 함수로 구성되어 있습니다.
소셜 플랫폼 제공자를 파라미터로 받아 처리합니다.
소셜 토큰을 발급받는 api처리로 연결되며 발급 이후, 로그인 api를 호출합니다.
로그인 api의 결과를 화면이동을 위한 LoginResponseType으로 case화 하여 반환합니다.
LoginViewModel
LoginViewModel은 로그인 처리를 위한 Action은 loginButtonDidTap와 Swipe 인덱스를 눌렀을때를 받고 있어요!
State 값으로는 login 결과 상태와, 스와이프 이미지 인덱스를 반환합니다.
🚀 PR Point
SwipeView 관련
사실 괜히 복잡하기만 해졌다는 생각입니다.
따라서 원래 버전으로 롤백을 할지 의견 부탁 드립니다.
bundle Identifier 관련
로그인 결과 값에 따른 화면 전환
DSKit 폰트 처리
📸 스크린샷
✅ CheckList
🔗 Issue
Resolved #91