Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SaveTools is too eager to correct errors #1

Open
1point7point4 opened this issue Aug 30, 2021 · 1 comment
Open

SaveTools is too eager to correct errors #1

1point7point4 opened this issue Aug 30, 2021 · 1 comment

Comments

@1point7point4
Copy link

First off, thanks for making this mod! It's nice to be able to repair tools ^^

Description

With that said, it doesn't seem to handle configs very well – every 10 seconds, MultiMC logs the following:

[<hh>:<mm>:<ss>] [Thread-1/WARN] [ne.mi.fm.co.ConfigFileTypeHandler/CONFIG]: Configuration file /Applications/MultiMC.app/Data/instances/Desutche/.minecraft/config/savetools-client.toml is not correct. Correcting.

This floods my logs to the point where it starts to cause lag.

In addition, some issues show up when I try to change the config file:

  • Trying to change comments doesn't work; they're changed back when the log above appears.
  • Changing the blacklist's contents doesn't work; same issue as above.
  • Changing the order of options doesn't work; they get their order changed to what they are by default.
  • The option enablelistfiler is misspelled; for backwards compatibility you'd need to support the misspelled version whether you fix this or not.

Notes

You might want to see if you can replicate this; check your logs while minecraft is launched with the mod installed. I haven't tested it but MultiMC probably isn't the cause (it doesn't alter the game, just the launch process).

Curiously, the timestamp always ends with a 9.

Some things about the config work fine:

  • Editing numbers and booleans
  • Backups (though all the file operations here might be a problem)

Screenshots

Screen Shot 2021-08-30 at 10 03 36
Screen Shot 2021-08-30 at 10 17 42

Please let me know if there's anything I do to help fix the issue; unfortunately, I don't know very much Java and never used Gradle or the Forge API.

@sjcl
Copy link
Member

sjcl commented Aug 30, 2021

Thank you for the report :)

Could you tell me what versions of Minecraft, Forge, SaveTools, and ClothConfig you have?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants