Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement proper email validation on registration #1703

Open
jiru opened this issue Oct 18, 2018 · 0 comments
Open

Implement proper email validation on registration #1703

jiru opened this issue Oct 18, 2018 · 0 comments
Labels
bug Issue that describes a problem with a feature that doesn't work as expected.

Comments

@jiru
Copy link
Member

jiru commented Oct 18, 2018

Currently, when someone wants to register, we check his/her email address using a regular expression. This is a problem because:

  1. The current regular expression doesn’t look good. For example, it doesn’t match the rather frequently used character + (hence the bug label of this issue).
  2. Using a regular expression is not good in the first place, because there are no correct regular expressions for emails.

So: better send a confirmation link by email instead.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Issue that describes a problem with a feature that doesn't work as expected.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jiru