Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: propose gas limit validation #2907

Merged
merged 1 commit into from
Dec 4, 2024
Merged

Conversation

mfrankovi
Copy link
Contributor

  • Allow setting propose gas limits in config file as hex by modifying getConfigDataAsUInt to accept hex strings
  • Remove validation of propose gas limits from FullNodeConfig::validate since the validation depends if over the cornus HF. Add validation in DagBlockProposer constructor by reducing the value to the maximum gas limit allowed

@mfrankovi mfrankovi force-pushed the propose_gas_limit_fix branch from a034041 to 69a4484 Compare December 3, 2024 15:13
@mfrankovi mfrankovi merged commit 6ac9d82 into develop Dec 4, 2024
1 check passed
@mfrankovi mfrankovi deleted the propose_gas_limit_fix branch December 4, 2024 10:13
@taraxadeploy
Copy link
Collaborator

prnet cleaned-up successfully

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants