Use smartpointers for DagBlock and avoid unnecessary copies #2883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Related Issue |
JakubFornadel
force-pushed
the
issue-2869/refacgor_dag_sync_packet
branch
from
d67062a to
7f02708
Compare
JakubFornadel
requested review from
mfrankovi,
kstdl and
MatusKysel
and removed request for
mfrankovi and
kstdl
JakubFornadel
changed the title
JakubFornadel
force-pushed
the
issue-2869/refacgor_dag_sync_packet
branch
from
7f02708 to
2d1bd42
Compare
|
prnet cleaned-up successfully |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of the codebase was using raw DagBlock objects, another part was using std::shared_ptr. As a result, we were making DagBlock object copies a lot, which is expensive... see
DagManager::getDagBlock(const blk_hash_t &hash)methodThe codebase is now united and we are using only smart pointers...
Purpose
How does the solution address the problem
Changes made