This repository has been archived by the owner on Oct 15, 2024. It is now read-only.
FSD-717 - Harshal - Add ingress for artemis to access management console #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syed-faraz
reviewed
Jan 27, 2023
| namespace: {{ .Release.Namespace }} | ||
| spec: | ||
| rules: | ||
| - host: {{ include "artemis.fullname" . }}.ci.tarabutgateway.io |
There was a problem hiding this comment.
other environments will also be included like, sandbox and prod and also sau. Better to interpolate the full host.
There was a problem hiding this comment.
Can we test the chart with this PR, or we should interpolate and then do the testing?
There was a problem hiding this comment.
@syed-faraz Can you check now?
…ch would need to be set during chart installation
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to test the workflow by adding an ingress to allow access for artemis management console. Once the workflow is tested, we will templetize for other higher environments.