Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config questions of notebook and scripts of feature matching #14

Open
ewrfcas opened this issue Sep 1, 2022 · 2 comments
Open

Config questions of notebook and scripts of feature matching #14

ewrfcas opened this issue Sep 1, 2022 · 2 comments

Comments

@ewrfcas
Copy link

ewrfcas commented Sep 1, 2022

Thanks for your excellent work.

In 'FeatureMatching/scripts/reproduce_test/outdoor_ds_quadtree.sh', 'configs/loftr/outdoor/loftr_ds_quadtree.py' is used. But this config is different from 'cvpr_ds_config.py'.

In 'FeatureMatching/notebooks' only default settings from 'cvpr_ds_config.py' are used. Which setting should be correct for the QuadTreeAttention in feature matching?

@ewrfcas
Copy link
Author

ewrfcas commented Sep 1, 2022

For example, COARSE.TOPKS in cvpr_ds_config.py is [16,8,8], but in loftr_ds_quadtree.py is [32,16,16]. Will it influence the inference with a pre-trained model?

@Tangshitao
Copy link
Owner

The code of notebook is from the original LoFTR. Please don't use that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants