fix(react-query): make sure promises are always finalized #8211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
otherwise, there can be cases with multiple observers where we have listeners already, but still need to finalize
☁️ Nx Cloud ReportCI is running/has finished running commands for commit ef9efc2. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 2 targetsSent with 💌 from NxCloud. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8211 +/- ##
=========================================
+ Coverage 0 81.79% +81.79%
=========================================
Files 0 26 +26
Lines 0 357 +357
Branches 0 97 +97
=========================================
+ Hits 0 292 +292
- Misses 0 56 +56
- Partials 0 9 +9
|
KATT
reviewed
Oct 23, 2024
| @@ -150,10 +150,8 @@ export function useBaseQuery< | |||
| client.getQueryCache().get(defaultedOptions.queryHash)?.promise | |||
|
|
|||
| promise?.catch(noop).finally(() => { | |||
| if (!observer.hasListeners()) { | |||
There was a problem hiding this comment.
Wow, I should know by now not to do premature optimizations 😬
There was a problem hiding this comment.
😂 seems like we removed all the checks that were initially added because we found a case where that broke it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
otherwise, there can be cases with multiple observers where we have listeners already, but still need to finalize