Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configuration should be versioned #3

Closed
bendrucker opened this issue Sep 8, 2021 · 0 comments · Fixed by #4
Closed

Configuration should be versioned #3

bendrucker opened this issue Sep 8, 2021 · 0 comments · Fixed by #4

Comments

@bendrucker
Copy link
Contributor

The configuration here is implicitly associated with the version of TFLint that runs it. In the future, new versions of TFLint could make breaking changes, such as removing top level configuration, rules, etc. When we update this config to match, that will also be a breaking change. It is unsafe for other repos to refer to the default branch in this repo.

Configuration should be versioned with semver major/minor/full tags so that consumers can initially refer to v1 and receive only non-breaking updates.

In the future we might look at specifying the TFLint version in this config:

terraform-linters/tflint#1217

The required_version (or similar) could be parsed out of the config and used to download the latest matching TFLint version. This seems like yet another use case for an action that can do semver constraint resolution on a list of GitHub releases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant