Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Regression: 'Add Tags' search result is no longer ordered by exactness #687

Open
3 tasks done
Tishj opened this issue Jan 5, 2025 · 1 comment
Open
3 tasks done
Labels
Priority: High An important issue requiring attention TagStudio: Search The TagStudio search engine TagStudio: Tags Relating to the TagStudio tag system Type: Bug Something isn't working as intended Type: QoL A quality of life (QoL) enhancement or suggestion Type: UI/UX User interface and/or user experience
Milestone

Comments

@Tishj
Copy link

Tishj commented Jan 5, 2025

Checklist

  • I am using an up-to-date version.
  • I have read the documentation.
  • I have searched existing issues.

TagStudio Version

Alpha 9.5

Operating System & Version

Windows 10

Description

Previously, when searching for a tag, results would be ordered (probably as a fortunate coincidence) by how exact the match is

If we for example take these words:
Hand
Handlebar
Handle

Previously a search for h up to hand would get Hand, handl and handle result in Handle and handleb up to handlebar would result in Handlebar

Now it seems to be random, or based on the order the tags were created in, a search for hand could have Handlebar as the first result.
The order in which the results are given is relevant when 'enter' is used to select the tag, which I would think is the preferred way of adding tags

@Tishj Tishj added the Type: Bug Something isn't working as intended label Jan 5, 2025
@CyanVoxel CyanVoxel added Type: QoL A quality of life (QoL) enhancement or suggestion Type: UI/UX User interface and/or user experience TagStudio: Search The TagStudio search engine TagStudio: Tags Relating to the TagStudio tag system labels Jan 6, 2025
@CyanVoxel CyanVoxel moved this to 🛠 Ready for Development in TagStudio Development Jan 6, 2025
@CyanVoxel CyanVoxel added this to the SQL Parity milestone Jan 6, 2025
@CyanVoxel
Copy link
Member

I've also noticed this, thank you for opening up an issue for it!

The current tag search order present in v9.4 came from #329, which doesn't appear to have been ported over to the main branch yet. That one also leveraged tag display names when it could, which also still aren't currently on main yet.

@CyanVoxel CyanVoxel added the Priority: Medium An issue that shouldn't be be saved for last label Jan 6, 2025
@CyanVoxel CyanVoxel added Priority: High An important issue requiring attention and removed Priority: Medium An issue that shouldn't be be saved for last labels Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: High An important issue requiring attention TagStudio: Search The TagStudio search engine TagStudio: Tags Relating to the TagStudio tag system Type: Bug Something isn't working as intended Type: QoL A quality of life (QoL) enhancement or suggestion Type: UI/UX User interface and/or user experience
Projects
Status: 🛠 Ready for Development
Development

No branches or pull requests

2 participants