Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Regression: Tags with spaces in the name can no longer be found by removing the spaces #681

Open
3 tasks done
Tishj opened this issue Jan 4, 2025 · 4 comments
Open
3 tasks done
Labels
TagStudio: Search The TagStudio search engine TagStudio: Tags Relating to the TagStudio tag system Type: Wontfix This will not be worked on

Comments

@Tishj
Copy link

Tishj commented Jan 4, 2025

Checklist

  • I am using an up-to-date version.
  • I have read the documentation.
  • I have searched existing issues.

TagStudio Version

main (9.5 dev)

Operating System & Version

Windows 10

Description

Previously it was possible to find My Tag by searching for mytag, which is no longer possible.
I noticed that my_tag does work, so I'm wondering if this is just an expected behavior change?

I noticed #112 discusses this, and links to #606 as a PR to fix the issue

Expected Behavior And Steps to Reproduce

Create My Tag
Add it to an entry
Search for mytag
Find the entry that is tagged with My Tag (current behavior: it's not found)

@Tishj Tishj added the Type: Bug Something isn't working as intended label Jan 4, 2025
@Tishj
Copy link
Author

Tishj commented Jan 4, 2025

I can live with the underscore version (my_tag), "My Tag" is not something I would ever use personally
If this is expected behavior now, perhaps it should be mentioned in the 9.4 -> 9.5 changelog when that is released (if this isn't already planned to be included)

@CyanVoxel
Copy link
Member

Yes, this is the new expected behavior. The previous behavior was the result of a bug in the parser rather than an intentional design decision - I'll make sure that this is documented in the changelog for 9.5's release 👍

@CyanVoxel CyanVoxel added Type: Wontfix This will not be worked on and removed Type: Bug Something isn't working as intended labels Jan 4, 2025
@Tishj
Copy link
Author

Tishj commented Jan 5, 2025

Just wanted to circle back to this a little, I find I'm really missing the convenience of not having to substitute spaces for tabs, so I'm likely going to add an alias for that to all tags that have spaces

Is there a possibility this can become a configuration option? To automatically add an alias to a tag that has spaces in the name with the spaces removed? opt-in ofcourse

@CyanVoxel CyanVoxel reopened this Jan 6, 2025
@CyanVoxel
Copy link
Member

If it's a convenience issue, which I suppose omitting a character in place of a space is more convenient than typing an underscore, then it may be possible to add that back as an intentional feature. Off the top of my head I don't see why not, but I'm also not intimately familiar with the new parser system. Perhaps as a new feature request?

@CyanVoxel CyanVoxel added TagStudio: Tags Relating to the TagStudio tag system TagStudio: Search The TagStudio search engine labels Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TagStudio: Search The TagStudio search engine TagStudio: Tags Relating to the TagStudio tag system Type: Wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants