Peer dependency warning with Restify 8

[ahce]

Description

npm WARN [email protected] requires a peer of [email protected] - 7.x.x but none is installed. You must install peer dependencies yourself.

Steps to reproduce

npm install --save restify-cors-middleware

Environment

• OS: Windows 10 Pro 1809
• Node.js: 10.15.1
• restify: 8.0.0
• restify-cors-middleware: 1.1.1

[ekristen]

Please publish new version to update peer dependency.

[yagomassiah]

Having the same issue, and it doesn't seem to work either with restify 8

[apnorton]

Same issue here with Restify 8. There doesn't seem to be much discussion happening on this package --- is it still maintained?

[yagomassiah]

@apnorton Well I completely abandoned restify for things other than prototyping, the last commit here was a year ago. And I had problems with other important contributors to restify packages too, like restify-paginate. Hope you have more luck than I did.

[drwharris]

I am using this with restify 8.3.3 with no issues other than the NPM peer dependency warning. The really dumb part of all this is that restify is relying on a 3rd party for a crucial middleware and even worse is that this repo is closed, I've put forward a pull request but if no one is monitoring it :(

[JimPatterson]

It seems the maintainers have dark. I have forked this repo and included the open PRs and also fixed the issue with vary header. See https://www.npmjs.com/package/restify-cors-middleware2 / https://github.com/DatatracCorporation/restify-cors-middleware2 if you need a fix.