Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoiding hash in API calls breaks client only mode #306

Closed
mercs600 opened this issue Feb 17, 2023 · 0 comments · Fixed by #308
Closed

Avoiding hash in API calls breaks client only mode #306

mercs600 opened this issue Feb 17, 2023 · 0 comments · Fixed by #308

Comments

@mercs600
Copy link
Contributor

When ssr:false is set for the client-side, the following condition causes rendering to break:

  const isDifferentPage = context.from?.path !== route.path
  if (isDynamicRoute(context.route) && isDifferentPage) {

This is because context.from is always available on the client-side and, additionally, the route middleware is always called on the initial render.

It should be fixed, we should provide client only mode as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant