Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools/camera shells out to curl #382

Closed
joschahenningsen opened this issue Apr 20, 2022 · 1 comment · Fixed by #386
Closed

tools/camera shells out to curl #382

joschahenningsen opened this issue Apr 20, 2022 · 1 comment · Fixed by #386
Assignees
@MatthiasReumann
Labels
enhancement New feature or request

Comments

@joschahenningsen
Copy link
Member

https://github.com/joschahenningsen/TUM-Live/blob/dev/tools/camera/camera.go#L92-L100

There is no need to require curl, the net/http package should be sufficient to make these requests.
@joschahenningsen joschahenningsen added the enhancement New feature or request label Apr 20, 2022
@MatthiasReumann MatthiasReumann self-assigned this Apr 23, 2022
@MatthiasReumann
Copy link
Collaborator

As it seems Digest Authentication isn't integrated in the net/http module yet (See: golang/go#29409)

So the question now is if we should include something like https://github.com/delphinus/go-digest-request, https://github.com/abbot/go-http-auth, or implement an own solution.

@MatthiasReumann MatthiasReumann mentioned this issue Apr 23, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MatthiasReumann MatthiasReumann

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove curl TUM-Dev/gocast
2 participants
@MatthiasReumann @joschahenningsen