Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Include room schedules #216

Closed
joschahenningsen opened this issue Oct 1, 2022 · 3 comments · Fixed by #221
Closed

[Feature] Include room schedules #216

joschahenningsen opened this issue Oct 1, 2022 · 3 comments · Fixed by #221
Labels
feature New feature or request frontend Related to the frontend

Comments

@joschahenningsen
Copy link
Member

Is your feature request related to a problem? Please describe.
The roomfinder made by the department of physics includes a calendar with the schedule for a room which I find quite useful: https://www.ph.tum.de/about/visit/roomfinder/?room=5510.02.001&language=de

Describe the solution you'd like
Perhaps we could add a similar feature to NavigaTUM.

Describe alternatives you've considered
Look up the schedule on tumonline. Maybe add a link to e.g. https://campus.tum.de/tumonline/ee/ui/ca2/app/desktop/#/pl/ui/$ctx/wbKalender.wbRessource?$ctx=design=ca2;header=max;lang=de&pResNr=12543 ?

@joschahenningsen joschahenningsen added the feature New feature or request label Oct 1, 2022
@CommanderStorm CommanderStorm changed the title Include room schedules[Feature] [Feature] Include room schedules Oct 1, 2022
@CommanderStorm CommanderStorm added the frontend Related to the frontend label Oct 1, 2022
@CommanderStorm
Copy link
Member

I am not convinced that this schedule is useful for most people (I agree that for lecturers this is essential).
⇒ This should be a lazy-loaded subcomponent and not something that is shown always as in the physics roomfinder.
Do you agree with this assessment? If not, how do you use this feature?

@joschahenningsen
Copy link
Member Author

Completely agree. I need to view room schedules quite frequently to plan livestreams. Having to find the right link in tumonline is always a hassle. So linking there would already be very useful.

@octycs
Copy link
Contributor

octycs commented Oct 1, 2022

Creating a link to TUMonline should be relatively easy, because the relevant URL section is given by entry["tumonline_data"]["calendar"] (https://github.com/TUM-Dev/NavigaTUM/blob/main/data/data_format_geo-entry.yaml#L226):

if entry["tumonline_data"]["calendar"] is not None:
    url = f"https://campus.tum.de/tumonline/{entry['tumonline_data']['calendar']}"

Like all the raw TUMonline data it is at the moment stripped on export.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request frontend Related to the frontend
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants