Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

render_functions.py : get_names_at_location Capitalization #43

Open
rinqtmith opened this issue Jan 12, 2021 · 1 comment
Open

render_functions.py : get_names_at_location Capitalization #43

rinqtmith opened this issue Jan 12, 2021 · 1 comment

Comments

@rinqtmith
Copy link

rinqtmith commented Jan 12, 2021

In the function, names is capitalized after joined together. If there are two entities there only first letter is capitalized.
It is better to capitalize then join them.

From: (Player remains of troll)

names = ", ".join(
        entity.name for entity in game_map.entities if entity.x == x and entity.y == y
    )

    return names.capitalize()

To: (Player Remains of troll)

names = ", ".join(entity.name.capitalize() for entity in game_map.entities
                      if entity.x == x and entity.y == y)

    return names
@HexDecimal
Copy link
Collaborator

Technically I think the previous grammar is correct. At least in English a comma doesn't automatically capitalize the next letter.

The all-caps version does look a little bit better, but maybe that's subjective.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants