Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remote copy sys temporary #12

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

wangyoucao577
Copy link
Collaborator

It requires all system packages have ten_package target for the copying, which is not true for some system packages such as ten_runtime_go, agora_rtc_sdk, azure_speech_sdk, nlohmann_json, etc. Update all of them seem tricky. On the other hand, currently only cpp app requires it, but mostly we're using go or python main. So try to disable it by default. It's able to enable it on branch for cpp apps before we figure out better solution.

Copy link
Member

@halajohn halajohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个改法不行, 会导致 CI fail, 可见我发的一笔内部 jenkins CI. 可能比较可行的作法是, 把 get_used_ten_pkgs.py 从 exec_script 改成动态的 action. 然后借由类似 gn desc out/linux/x64/ //core/src/ten_runtime:ten_runtime 的这种方法来 check 想要的 gn target 是否存在, 存在的话就纳入到 TEN app 的 gn 构件流程中, 反之就不要 deps += 它. 换句话说, 把 exec_script 这个在 gn gen 时期所判断的动作, 改成在 gn build 时期做, 并且借由 gn desc 来让 gn build 时期可以取得 gn gen 时期所产生的 information, 借由这个 information 来做事情.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants