From 945f536c67d74e9f741f453323a654057d743e54 Mon Sep 17 00:00:00 2001 From: Sweta Date: Sun, 27 Mar 2022 20:05:43 -0400 Subject: [PATCH 1/6] rephrased instructions for searching students --- .../instructor-search-bar.component.html | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/web/app/pages-instructor/instructor-search-page/instructor-search-bar/instructor-search-bar.component.html b/src/web/app/pages-instructor/instructor-search-page/instructor-search-bar/instructor-search-bar.component.html index b326634dd9e..b65de33d9c2 100644 --- a/src/web/app/pages-instructor/instructor-search-page/instructor-search-bar/instructor-search-bar.component.html +++ b/src/web/app/pages-instructor/instructor-search-page/instructor-search-bar/instructor-search-bar.component.html @@ -1,13 +1,13 @@
- You can search for students from all your courses here. + You can search for students (by name or email) from all your courses here.
Search Tips:
  • Put more keywords to search for more precise results.
  • -
  • Put quotation marks around words "[any word]" to search for an exact phrase in an exact order.
  • +
  • Put quotation marks around words "[any word]" to search for an exact phrase in an exact order. e.g., "John Doe".
From b2d4987de00ee77690e274251a9f26f016e4753b Mon Sep 17 00:00:00 2001 From: Sweta Date: Sun, 27 Mar 2022 20:25:42 -0400 Subject: [PATCH 2/6] removed students title from the search component --- .../student-result-table/student-result-table.component.html | 1 - 1 file changed, 1 deletion(-) diff --git a/src/web/app/pages-instructor/instructor-search-page/student-result-table/student-result-table.component.html b/src/web/app/pages-instructor/instructor-search-page/student-result-table/student-result-table.component.html index 86fc61b9ba9..d7f3720fc13 100644 --- a/src/web/app/pages-instructor/instructor-search-page/student-result-table/student-result-table.component.html +++ b/src/web/app/pages-instructor/instructor-search-page/student-result-table/student-result-table.component.html @@ -1,5 +1,4 @@
-
Students
[{{course.courseId}}]
From bd6a1f41f7add03c034e2c7b0532fb4a9414f2df Mon Sep 17 00:00:00 2001 From: Sweta Date: Sun, 27 Mar 2022 21:01:12 -0400 Subject: [PATCH 3/6] removed blue outline of the search results panel --- .../student-result-table.component.html | 32 ++++++++----------- 1 file changed, 14 insertions(+), 18 deletions(-) diff --git a/src/web/app/pages-instructor/instructor-search-page/student-result-table/student-result-table.component.html b/src/web/app/pages-instructor/instructor-search-page/student-result-table/student-result-table.component.html index d7f3720fc13..385ceeb825c 100644 --- a/src/web/app/pages-instructor/instructor-search-page/student-result-table/student-result-table.component.html +++ b/src/web/app/pages-instructor/instructor-search-page/student-result-table/student-result-table.component.html @@ -1,19 +1,15 @@ -
-
-
-
[{{course.courseId}}]
-
- - -
-
+
+
[{{course.courseId}}]
+
+ +
-
+
\ No newline at end of file From 9eaa91871c30cfe5a1dd1c1a5945abbcd88a942f Mon Sep 17 00:00:00 2001 From: Sweta Date: Wed, 30 Mar 2022 17:10:09 -0400 Subject: [PATCH 4/6] updated snapshot --- ...tructor-search-page.component.spec.ts.snap | 719 +++++++++--------- 1 file changed, 353 insertions(+), 366 deletions(-) diff --git a/src/web/app/pages-instructor/instructor-search-page/__snapshots__/instructor-search-page.component.spec.ts.snap b/src/web/app/pages-instructor/instructor-search-page/__snapshots__/instructor-search-page.component.spec.ts.snap index b029bea5e22..688c4688468 100644 --- a/src/web/app/pages-instructor/instructor-search-page/__snapshots__/instructor-search-page.component.spec.ts.snap +++ b/src/web/app/pages-instructor/instructor-search-page/__snapshots__/instructor-search-page.component.spec.ts.snap @@ -20,7 +20,7 @@ exports[`InstructorSearchPageComponent should snap with a search key 1`] = `
- You can search for students from all your courses here. + You can search for students (by name or email) from all your courses here.
"[any word]" - to search for an exact phrase in an exact order. + to search for an exact phrase in an exact order. e.g., "John Doe".
@@ -91,7 +91,7 @@ exports[`InstructorSearchPageComponent should snap with a student table 1`] = `
- You can search for students from all your courses here. + You can search for students (by name or email) from all your courses here.
"[any word]" - to search for an exact phrase in an exact order. + to search for an exact phrase in an exact order. e.g., "John Doe".
@@ -141,385 +141,372 @@ exports[`InstructorSearchPageComponent should snap with a student table 1`] = `
- Students + [test-exa.demo]
-
-
- [test-exa.demo] -
+
- -
+ - - + + - - - - - - - - - - - + + + + + - - - - - - + + + + + + + - - + + + + + + + + - - - - - - + + + - - + + + + + + + + - - - - - - + + + - - + + + + + + + + - - - - - - + + + - - -
+ Photo + -
- Photo - - Section - - - - - Team - - - - - Student Name - - - - - Status - - - - - Email - - - - - Action(s) -
+ Team + + + + + Student Name + - - - - View Photo - - - - Tutorial Group 1 - - Team 1 - - tester - - Joined - - tester@tester.com - + + + + Status + + + + + Email + + + + + Action(s) +
+ + - - View - - - Edit - - - - All Records - -
+ Tutorial Group 1 + + Team 1 + + tester + + Joined + + tester@tester.com + + + View + + - - - - View Photo - - - - Tutorial Group 1 - - Team 1 - - Benny Charles - - Joined - - benny.c.tmms@gmail.tmt - + + + All Records + +
+ + - - View - - - Edit - - - - All Records - -
+ Tutorial Group 1 + + Team 1 + + Benny Charles + + Joined + + benny.c.tmms@gmail.tmt + + + View + + + Edit + + - - - View Photo - - - - Tutorial Group 1 - - Team 1 - - Alice Betsy - - Joined - - alice.b.tmms@gmail.tmt - + + All Records + +
+ + - - View - - - Edit - - - - All Records - -
+ Tutorial Group 1 + + Team 1 + + Alice Betsy + + Joined + + alice.b.tmms@gmail.tmt + + + View + + + Edit + + - - - View Photo - - - - Tutorial Group 1 - - Team 1 - - Danny Engrid - - Joined - - danny.e.tmms@gmail.tmt - + + All Records + +
+ + - - View - - - Edit - - - - All Records - -
-
-
+ View Photo + + + + + Tutorial Group 1 + + + Team 1 + + + Danny Engrid + + + Joined + + + danny.e.tmms@gmail.tmt + + + + View + + + Edit + + + + All Records + + + + +
-
+
@@ -547,7 +534,7 @@ exports[`InstructorSearchPageComponent should snap with default fields 1`] = `
- You can search for students from all your courses here. + You can search for students (by name or email) from all your courses here.
"[any word]" - to search for an exact phrase in an exact order. + to search for an exact phrase in an exact order. e.g., "John Doe".
From 2d5d0a2a4c1ccbbdcfb16fd225ea96f904aef323 Mon Sep 17 00:00:00 2001 From: Sweta Date: Wed, 30 Mar 2022 17:45:36 -0400 Subject: [PATCH 5/6] fixed some lint errors --- .../student-result-table/student-result-table.component.html | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/web/app/pages-instructor/instructor-search-page/student-result-table/student-result-table.component.html b/src/web/app/pages-instructor/instructor-search-page/student-result-table/student-result-table.component.html index 385ceeb825c..154e69bddcd 100644 --- a/src/web/app/pages-instructor/instructor-search-page/student-result-table/student-result-table.component.html +++ b/src/web/app/pages-instructor/instructor-search-page/student-result-table/student-result-table.component.html @@ -12,4 +12,4 @@ (removeStudentFromCourseEvent)="removeStudent(course.students, $event)">
-
\ No newline at end of file +
From 54ef56fcbe316bda680d7094118f0025aed51055 Mon Sep 17 00:00:00 2001 From: Sweta Date: Thu, 7 Apr 2022 15:57:56 -0400 Subject: [PATCH 6/6] rephrased instructions to include more fields for search --- .../instructor-search-page.component.spec.ts.snap | 12 ++++++------ .../instructor-search-bar.component.html | 4 ++-- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/src/web/app/pages-instructor/instructor-search-page/__snapshots__/instructor-search-page.component.spec.ts.snap b/src/web/app/pages-instructor/instructor-search-page/__snapshots__/instructor-search-page.component.spec.ts.snap index 688c4688468..b0c76fcaf79 100644 --- a/src/web/app/pages-instructor/instructor-search-page/__snapshots__/instructor-search-page.component.spec.ts.snap +++ b/src/web/app/pages-instructor/instructor-search-page/__snapshots__/instructor-search-page.component.spec.ts.snap @@ -20,7 +20,7 @@ exports[`InstructorSearchPageComponent should snap with a search key 1`] = `
- You can search for students (by name or email) from all your courses here. + You can search for students (by section name, team name, student name, or email) from all your courses here.
"[any word]" - to search for an exact phrase in an exact order. e.g., "John Doe". + to search for an exact phrase in an exact order. e.g. "John Doe".
@@ -91,7 +91,7 @@ exports[`InstructorSearchPageComponent should snap with a student table 1`] = `
- You can search for students (by name or email) from all your courses here. + You can search for students (by section name, team name, student name, or email) from all your courses here.
"[any word]" - to search for an exact phrase in an exact order. e.g., "John Doe". + to search for an exact phrase in an exact order. e.g. "John Doe".
@@ -534,7 +534,7 @@ exports[`InstructorSearchPageComponent should snap with default fields 1`] = `
- You can search for students (by name or email) from all your courses here. + You can search for students (by section name, team name, student name, or email) from all your courses here.
"[any word]" - to search for an exact phrase in an exact order. e.g., "John Doe". + to search for an exact phrase in an exact order. e.g. "John Doe".
diff --git a/src/web/app/pages-instructor/instructor-search-page/instructor-search-bar/instructor-search-bar.component.html b/src/web/app/pages-instructor/instructor-search-page/instructor-search-bar/instructor-search-bar.component.html index b65de33d9c2..c3ee67a745a 100644 --- a/src/web/app/pages-instructor/instructor-search-page/instructor-search-bar/instructor-search-bar.component.html +++ b/src/web/app/pages-instructor/instructor-search-page/instructor-search-bar/instructor-search-bar.component.html @@ -1,13 +1,13 @@
- You can search for students (by name or email) from all your courses here. + You can search for students (by section name, team name, student name, or email) from all your courses here.
Search Tips:
  • Put more keywords to search for more precise results.
  • -
  • Put quotation marks around words "[any word]" to search for an exact phrase in an exact order. e.g., "John Doe".
  • +
  • Put quotation marks around words "[any word]" to search for an exact phrase in an exact order. e.g. "John Doe".