Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assertion turning switch device On with 0.6.5 #119

Closed
dlarrick opened this issue Feb 17, 2019 · 0 comments
Closed

Assertion turning switch device On with 0.6.5 #119

dlarrick opened this issue Feb 17, 2019 · 0 comments

Comments

@dlarrick
Copy link

I am seeing the following trying to turn a switch device on. Turning off works fine, and dimmer devices also work fine.

Feb 16 18:10:02 piscine insteon-mqtt[7574]: 2019-02-16 18:10:02 DEBUG Switch: Switch message insteon/22.aa.97/set b'ON'
Feb 16 18:10:02 piscine insteon-mqtt[7574]: 2019-02-16 18:10:02 DEBUG MsgTemplate: Input template render: '{ "cmd" : "on" }'
Feb 16 18:10:02 piscine insteon-mqtt[7574]: 2019-02-16 18:10:02 INFO Switch: Switch input command: {'cmd': 'on'}
Feb 16 18:10:02 piscine insteon-mqtt[7574]: 2019-02-16 18:10:02 INFO Switch: Switch 22.aa.97 cmd: on None
Feb 16 18:10:02 piscine insteon-mqtt[7574]: 2019-02-16 18:10:02 ERROR Switch: Invalid switch on/off command: {'cmd': 'on'}
Feb 16 18:10:02 piscine insteon-mqtt[7574]: Traceback (most recent call last):
Feb 16 18:10:02 piscine insteon-mqtt[7574]:   File "/opt/insteon-mqtt/lib/python3.5/site-packages/insteon_mqtt/mqtt/Switch.py", line 232, in _input_on_off
Feb 16 18:10:02 piscine insteon-mqtt[7574]:     self.device.set(level=is_on, mode=mode)
Feb 16 18:10:02 piscine insteon-mqtt[7574]:   File "/opt/insteon-mqtt/lib/python3.5/site-packages/insteon_mqtt/device/Switch.py", line 214, in set
Feb 16 18:10:02 piscine insteon-mqtt[7574]:     self.on(group, mode, on_done)
Feb 16 18:10:02 piscine insteon-mqtt[7574]:   File "/opt/insteon-mqtt/lib/python3.5/site-packages/insteon_mqtt/device/Switch.py", line 144, in on
Feb 16 18:10:02 piscine insteon-mqtt[7574]:     assert isinstance(mode, on_off.Mode)
Feb 16 18:10:02 piscine insteon-mqtt[7574]: AssertionError

I am not currently set up to create a pull request but I believe this is the fix (in device/Switch.py).:

--- Switch.py~	2019-02-16 11:49:52.752648353 -0500
+++ Switch.py	2019-02-16 18:16:53.457081473 -0500
@@ -211,7 +211,7 @@
                    completed.  Signature is: on_done(success, msg, data)
         """
         if level:
-            self.on(group, mode, on_done)
+            self.on(group, level, mode, on_done)
         else:
             self.off(group, mode, on_done)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant