-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for manual mode state reporting #104
Comments
You are missing Switch - switches can send manual dim up/down messages as well.
Also, I chose the numbers 0,1 and 2 for OpenHAB compatibility (these are the numbers used in the InsteonPLM binding). Using different numbers causes some compatibility problems. OpenHab users would have to transform every response in a custom table, and that might not be possible as without a separate topic we would have to be using a Json transform as well (and you can’t use two transforms). You could write a custom JavaScript transform, but then things are getting out of hand for a 1 digit offset.
An alternative would be to add an “OH_Man” option reporting 0,1 and 2 for compatibility.
What do you think?
Nick Waterton P.Eng
Sent from my iPhone
|
OK. Template parameters:
Optional config inputs for devices:
I'll fold in what you did into this system after merging in the fast on/off changes. |
Great,
Thanks.
Nick Waterton P.Eng
Sent from my iPhone
|
I haven't had time to update docs and tests yet, but you can find the code on the branch
|
manual branch has been merged to the dev branch in commit 3dc6079. Final API changed a little bit to make it more consistent with the other template values. See the config.yaml file for examples. |
Note: In 0.6.5, I changed the manual mode topics to force retain=False when sending. This stops the broker from saving a manual mode on/off message which isn't a persistent state like normal state updates. |
@NickWaterton
Currently manual up/down is not being reported. Commands are handled correctly, but only the final state is send when it's achieved. Add an optional manual_state output template to Dimmer, KeypadLinc, and Remote with template arguments 'mode_str' = 'up', 'down', 'stop' as well as 'mode' = +1, -1, 0. See PR #103 for details.
The text was updated successfully, but these errors were encountered: