-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure protocolRole
is maintained between query/read and subscribe/read.
#954
Conversation
🦋 Changeset detectedLatest commit: ec3b2c5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
TBDocs Report ✅ No errors or warnings @web5/api
@web5/crypto
@web5/crypto-aws-kms
@web5/dids
@web5/credentials
TBDocs Report Updated at 2024-10-21T13:46:32Z |
1b3b05c
to
d7a6958
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #954 +/- ##
=======================================
Coverage 93.35% 93.35%
=======================================
Files 118 118
Lines 33714 33734 +20
Branches 2736 2740 +4
=======================================
+ Hits 31473 31493 +20
Misses 2200 2200
Partials 41 41
|
Before this PR that were some inconsistencies with using
protocolRole
.There were instances where a user would query using a role but not be able to read the data of the given record because the role was not being applied. Same would happen during update/delete.
This PR allows the READ operation to inherit the
protocolRole
used for aquery
orsubscribe
if it exists.Additionally it provides the user the ability to provide a different role when performing an
update
ordelete
operation.