Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable event-stream by default for DwnApi. #910

Merged
merged 2 commits into from
Sep 26, 2024

Conversation

LiranCohen
Copy link
Member

For local subscriptions the EventEmitterStream was not being set when instantiating the DwnApi.

Copy link

changeset-bot bot commented Sep 25, 2024

🦋 Changeset detected

Latest commit: eb66ad6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@web5/api Patch
@web5/agent Patch
@web5/identity-agent Patch
@web5/proxy-agent Patch
@web5/user-agent Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Sep 25, 2024

TBDocs Report

✅ No errors or warnings

@web5/api

  • Project entry file: packages/api/src/index.ts

@web5/crypto

  • Project entry file: packages/crypto/src/index.ts

@web5/crypto-aws-kms

  • Project entry file: packages/crypto-aws-kms/src/index.ts

@web5/dids

  • Project entry file: packages/dids/src/index.ts

@web5/credentials

  • Project entry file: packages/credentials/src/index.ts

TBDocs Report Updated at 2024-09-26T20:14:45Z eb66ad6

Copy link

codecov bot commented Sep 25, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Please upload report for BASE (main@91ae997). Learn more about missing BASE report.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #910   +/-   ##
=======================================
  Coverage        ?   93.49%           
=======================================
  Files           ?      117           
  Lines           ?    33456           
  Branches        ?     2706           
=======================================
  Hits            ?    31281           
  Misses          ?     2136           
  Partials        ?       39           
Components Coverage Δ
agent 87.59% <66.66%> (?)
api 99.61% <ø> (?)
common 98.68% <ø> (?)
credentials 94.95% <ø> (?)
crypto 93.79% <ø> (?)
dids 97.77% <ø> (?)
identity-agent 96.42% <ø> (?)
crypto-aws-kms 100.00% <ø> (?)
proxy-agent 96.42% <ø> (?)
user-agent 96.57% <ø> (?)

@LiranCohen LiranCohen force-pushed the lirancohen/enable-event-stream branch from 7df1e47 to eb66ad6 Compare September 26, 2024 20:12
@LiranCohen LiranCohen marked this pull request as ready for review September 26, 2024 20:12
@LiranCohen LiranCohen changed the title [WIP] Enable event-stream by default for DwnApi. Enable event-stream by default for DwnApi. Sep 26, 2024
@LiranCohen LiranCohen merged commit d3b4728 into main Sep 26, 2024
35 checks passed
@LiranCohen LiranCohen deleted the lirancohen/enable-event-stream branch September 26, 2024 22:27
@github-actions github-actions bot mentioned this pull request Sep 26, 2024
This was referenced Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants