-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add grant to Record class methods #859
Conversation
🦋 Changeset detectedLatest commit: 22e29f3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
TBDocs Report 🛑 Errors: 0 @web5/api
@web5/crypto
@web5/crypto-aws-kms
@web5/dids
@web5/credentials
TBDocs Report Updated at 2024-09-03T14:57:55Z |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #859 +/- ##
==========================================
+ Coverage 93.40% 93.42% +0.02%
==========================================
Files 118 117 -1
Lines 33157 33260 +103
Branches 2650 2663 +13
==========================================
+ Hits 30969 31072 +103
Misses 2149 2149
Partials 39 39
|
2efa570
to
c9013b2
Compare
f4394ed
to
4d2f117
Compare
… tests for subscribe
2c04d13
to
28b772a
Compare
This PR fixes a bug where the
Record
class method which is retrieved with queries, reads, and writes did not respect the delegated permission state. TheRecord
class now accepts an optional PermissionsApi so that it can share the TTL cache with a caller. If one is not provided a new one is instantiated from the agent that is passed.Took advantage of removing the specific
CachedPermissions
class and wrapped it into thePermissionsApi
interface.Refactored some unnecessary abstractions when fetching the grant, added tests for missing cases and subscription cases.